Skip to content

feature: add duplicate GUIDs validation #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eduardosmaniotto wants to merge 3 commits into
base: master
Choose a base branch
from
+36 −5
Open

feature: add duplicate GUIDs validation #817

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4744366
test: add case to identify duplicate GUIDs
eduardosmaniotto Jul 7, 2026
b7d1d03
apply a proper duplicate GUID validation
eduardosmaniotto Jul 7, 2026
0bd92c5
code review: apply code suggestions
eduardosmaniotto Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions tests/MUnique.OpenMU.PlugIns.Tests/PlugInManagerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@
namespace MUnique.OpenMU.PlugIns.Tests;

using System.ComponentModel.Design;
using System.Reflection;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Abstractions;
using MUnique.OpenMU.PlugIns;
using MUnique.OpenMU.Tests;

/// <summary>
Expand All @@ -15,6 +17,24 @@ namespace MUnique.OpenMU.PlugIns.Tests;
[TestFixture]
public class PlugInManagerTest
{
/// <summary>
/// Tests that every <see cref="PlugInAttribute"/>-decorated type has a unique GUID.
/// </summary>
[Test]
public void AllPluginTypesHaveUniqueGuids()
{
var duplicates = AppDomain.CurrentDomain.GetAssemblies()
.SelectMany(a => a.DefinedTypes)
.Where(t => t.GetCustomAttribute<PlugInAttribute>() != null)
.GroupBy(t => t.GUID)
.Where(g => g.Count() > 1)
.ToList();
Comment thread
eduardosmaniotto marked this conversation as resolved.
Outdated

Assert.That(duplicates, Is.Empty,
$"Duplicate plugin GUIDs: {string.Join("; ", duplicates.Select(g =>
$"{g.Key} used by {string.Join(", ", g.Select(t => t.FullName))}"))}");
}

/// <summary>
/// Tests if registering a plugin type creates a proxy for it.
/// </summary>
Expand Down