feature: add duplicate GUIDs validation#817
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a proactive unit test designed to detect duplicate GUIDs among plugin types. By validating the uniqueness of these identifiers, the change helps prevent potential runtime conflicts and ensures better stability during future merges. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new unit test, AllPluginTypesHaveUniqueGuids, in PlugInManagerTest.cs to ensure that all plugin types decorated with PlugInAttribute have unique GUIDs. The reviewer suggested refactoring the test to use PlugInManager for discovering and registering plugins instead of querying AppDomain.CurrentDomain.GetAssemblies() directly, which avoids potential reflection-related exceptions and aligns with runtime plugin loading behavior.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Code Review
This pull request introduces duplicate GUID validation during plugin discovery and registration by adding a new validation method and a custom exception. It also refactors several logging statements to use structured logging instead of string interpolation. The feedback highlights that the validation is currently static and only checks the newly discovered plugins, meaning it will miss conflicts with already registered plugins. It is recommended to make the validation method an instance method, check against existing plugins, and handle potential null values for FullName.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This will prevent future merges with duplicated GUIDs.