Skip to content

feature: add duplicate GUIDs validation#817

Open
eduardosmaniotto wants to merge 3 commits into
MUnique:masterfrom
eduardosmaniotto:feature/duplicate-guid-test
Open

feature: add duplicate GUIDs validation#817
eduardosmaniotto wants to merge 3 commits into
MUnique:masterfrom
eduardosmaniotto:feature/duplicate-guid-test

Conversation

@eduardosmaniotto

@eduardosmaniotto eduardosmaniotto commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

This will prevent future merges with duplicated GUIDs.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a proactive unit test designed to detect duplicate GUIDs among plugin types. By validating the uniqueness of these identifiers, the change helps prevent potential runtime conflicts and ensures better stability during future merges.

Highlights

  • New Validation Test: Added a new test case, AllPluginTypesHaveUniqueGuids, to ensure that all types decorated with the PlugInAttribute maintain unique GUIDs.
  • Dependency Updates: Included necessary using statements for System.Reflection and MUnique.OpenMU.PlugIns to support the new validation logic.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new unit test, AllPluginTypesHaveUniqueGuids, in PlugInManagerTest.cs to ensure that all plugin types decorated with PlugInAttribute have unique GUIDs. The reviewer suggested refactoring the test to use PlugInManager for discovering and registering plugins instead of querying AppDomain.CurrentDomain.GetAssemblies() directly, which avoids potential reflection-related exceptions and aligns with runtime plugin loading behavior.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/MUnique.OpenMU.PlugIns.Tests/PlugInManagerTest.cs Outdated
@eduardosmaniotto eduardosmaniotto marked this pull request as draft July 7, 2026 21:17
@eduardosmaniotto eduardosmaniotto changed the title test: add case to identify duplicate GUIDs feature: add duplicate GUIDs validation Jul 7, 2026
@eduardosmaniotto eduardosmaniotto marked this pull request as ready for review July 7, 2026 21:55

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces duplicate GUID validation during plugin discovery and registration by adding a new validation method and a custom exception. It also refactors several logging statements to use structured logging instead of string interpolation. The feedback highlights that the validation is currently static and only checks the newly discovered plugins, meaning it will miss conflicts with already registered plugins. It is recommended to make the validation method an instance method, check against existing plugins, and handle potential null values for FullName.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/PlugIns/PlugInManager.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant