Add kwarg is_feasible_error to interior_point_Newton#556
Merged
kellertuer merged 2 commits intoJuliaManifolds:masterfrom Dec 4, 2025
Merged
Add kwarg is_feasible_error to interior_point_Newton#556kellertuer merged 2 commits intoJuliaManifolds:masterfrom
is_feasible_error to interior_point_Newton#556kellertuer merged 2 commits intoJuliaManifolds:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 91 91
Lines 9975 9976 +1
=========================================
+ Hits 9975 9976 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kellertuer
approved these changes
Dec 4, 2025
Member
kellertuer
left a comment
kellertuer
left a comment
There was a problem hiding this comment.
Thanks for fixing more typos (interesting that the new spellcheck did not spot them)
I am not 100% a fan of this, because it is a bit dangers especially for IPNewton, but it is carefully documented, so sure, we can do that.
kellertuer
referenced
this pull request
Dec 10, 2025
* fix early stopping in StopWhenRepeated * changelog * bump version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #540 (comment), this adds a kwarg to
interior_point_Newtonand to its state to customize what should happen for starting points, which are not feasible since sometimes I am an "adventurous numerics person" 😄