Fix early stopping in StopWhenRepeated (#558)

* fix early stopping in StopWhenRepeated
* changelog
* bump version

Author: JoshuaLampert

Changelog.md

@@ -6,7 +6,7 @@ The file was started with Version `0.4`.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [0.5.30] December 10, 2025
 
 ### Added
 
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 * fixed a few typos in the documentation (#557)
+* fixed a bug in `StopWhenRepeated` where it stopped already at initialisation if the interior stopping criterion was satisfied (#558)
 
 ## [0.5.29] November 26, 2025
 

Project.toml

@@ -1,7 +1,7 @@
 name = "Manopt"
 uuid = "0fc0a36d-df90-57f3-8f93-d78a9fc72bb5"
 authors = ["Ronny Bergmann <manopt@ronnybergmann.net>"]
-version = "0.5.29"
+version = "0.5.30"
 
 [deps]
 ColorSchemes = "35d6a980-a343-548e-a6ea-1d62b119f2f4"

src/plans/stopping_criterion.jl

@@ -1336,7 +1336,6 @@ function (c::StopWhenRepeated)(
     if k <= 0 # reset on init
         c.count = zero(c.count)
         c.at_iteration = -1
-        return c.stopping_criterion(p, s, k) # reset the criterion
     end
     # evaluate the inner stopping criterion
     stop = c.stopping_criterion(p, s, k)
@@ -1355,7 +1354,7 @@ function get_reason(sc::StopWhenRepeated)
     has_stopped = (sc.at_iteration >= 0)
     if (sc.at_iteration >= 0)
         s = has_stopped ? "reached" : "not reached"
-        c = sc.consecutive ? "consecutive " : ""
+        c = sc.consecutive ? "consecutive" : ""
         # we can only get the last reason, unless we do more allocations
         r = """At iteration $(sc.at_iteration), the stopping criterion $(typeof(sc.stopping_criterion)) has indicated to stop $(sc.n) $(c) times:
         $(sc.count) ≥ $(sc.n): $(s)