Skip to content

Prepare common data model 0.4 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcarion merged 3 commits into from
Sep 16, 2025
Merged

Prepare common data model 0.4 #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fd539d
bump CommonDataModel and remove @implement_diskarray
lupemba Jun 27, 2025
6d0d176
bump version number
lupemba Sep 12, 2025
ab5eb29
Update CI to run on latest version and any pre-release version.
lupemba Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ jobs:
matrix:
version:
- '1.10'
- '1.11'
- 'nightly'
- '1'
- 'pre'
os:
- ubuntu-latest
arch:
Expand Down
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "GRIBDatasets"
uuid = "82be9cdb-ee19-4151-bdb3-b400788d9abc"
authors = ["tcarion <tristan.carion@gmail.com> and contributors"]
version = "0.4.1"
version = "0.4.2"

[deps]
CommonDataModel = "1fbeeb36-5f17-413c-809b-666fb144f157"
Expand All @@ -12,7 +12,7 @@ GRIB = "b16dfd50-4035-11e9-28d4-9dfe17e6779b"
eccodes_jll = "b04048ba-5ccd-5610-b3f6-85129a548705"

[compat]
CommonDataModel = "0.3.4"
CommonDataModel = "0.4"
DataStructures = "0.18"
DiskArrays = "0.3, 0.4"
eccodes_jll = "~2.36"
Expand Down
1 change: 0 additions & 1 deletion src/variables.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ dataset(var::AbstractGRIBVariable) = var.ds

_get_dim(var::Variable, key::String) = _get_dim(var.dims, key)

DA.@implement_diskarray Variable
# Avoid DiskArrays.jl indexing when the parent is an Array
Base.getindex(var::Variable{T,N,Array{T,N}}, I::AbstractUnitRange...) where {T,N} =
getindex(parent(var), I...)
Expand Down
Loading