Merged
Conversation
Member
|
Thanks for the PR! This passes the test locally. Is there a way to manually trigger the checks here? |
Contributor
Author
I can make a commit bumping GRIBDdatasets.jl version to 0.4.2 in the evening. This should also trigger the CI again. |
Member
|
Thanks for the PR @lupemba! |
Contributor
Author
Thanks for making GRIBDatasets :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires: JuliaGeo/CommonDataModel.jl#35
The PR is related to the following issues JuliaGeo/CommonDataModel.jl#32
Content:
@implement_diskarray. This might not be needed. Keeping@implement_diskarraycould help with CommonDataModel backwards compatibilityThe PR have been tested offline by
All tests pass on my MacOS, Julia 1.11