Skip to content

Prepare common data model 0.4#44

Merged
tcarion merged 3 commits intoJuliaGeo:mainfrom
lupemba:Prepare-CommonDataModel-0.4
Sep 16, 2025
Merged

Prepare common data model 0.4#44
tcarion merged 3 commits intoJuliaGeo:mainfrom
lupemba:Prepare-CommonDataModel-0.4

Conversation

@lupemba
Copy link
Copy Markdown
Contributor

@lupemba lupemba commented Jun 27, 2025

This PR requires: JuliaGeo/CommonDataModel.jl#35

The PR is related to the following issues JuliaGeo/CommonDataModel.jl#32

Content:

  • Bump CommonDataModel to 0.4 (Not merged yet).
  • remove @implement_diskarray. This might not be needed. Keeping @implement_diskarray could help with CommonDataModel backwards compatibility

The PR have been tested offline by

@tcarion
Copy link
Copy Markdown
Member

tcarion commented Sep 12, 2025

Thanks for the PR! This passes the test locally. Is there a way to manually trigger the checks here?

@lupemba
Copy link
Copy Markdown
Contributor Author

lupemba commented Sep 12, 2025

Thanks for the PR! This passes the test locally. Is there a way to manually trigger the checks here?

I can make a commit bumping GRIBDdatasets.jl version to 0.4.2 in the evening. This should also trigger the CI again.

@tcarion tcarion merged commit 4145aaa into JuliaGeo:main Sep 16, 2025
6 checks passed
@tcarion
Copy link
Copy Markdown
Member

tcarion commented Sep 16, 2025

Thanks for the PR @lupemba!

@lupemba
Copy link
Copy Markdown
Contributor Author

lupemba commented Sep 16, 2025

Thanks for the PR @lupemba!

Thanks for making GRIBDatasets :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants