Update minimum supported Bitcoin Core version to 29.0#1782
Merged
kristapsk merged 1 commit intoJoinMarket-Org:masterfrom Oct 17, 2025
Merged
Update minimum supported Bitcoin Core version to 29.0#1782kristapsk merged 1 commit intoJoinMarket-Org:masterfrom
kristapsk merged 1 commit intoJoinMarket-Org:masterfrom
Conversation
roshii
approved these changes
Oct 2, 2025
f8ee4d5 to
f2d891a
Compare
Member
Author
|
Updated 29.0 to 29.2. Although we now support 30.0 in master, not yet the case with tests, as they need both privkeys and watchonly in the same wallet, which is not supported with descriptor wallets. |
We should not recommend anything older, there have been vulnerabilty fix. https://bitcoincore.org/en/2025/04/28/disclose-cve-2024-52919/
f2d891a to
f952d7d
Compare
Member
Author
|
Ci failure is unrelated, merging. |
For the record, this fix was also backported to bitcoin core v28.1 https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-28.1.md#p2p So perhaps supporting 28.3 shouldn't be an issue? |
kristapsk
added a commit
that referenced
this pull request
Oct 28, 2025
b4e3fdd Update minimum supported Bitcoin Core version to 28.1 (3np) Pull request description: Drop minimum supported Bitcoin Core version from 29.0 to 28.1. Minimum version was lifted in #1782. The motivating bitcoin-core issue was patched in 28.1. Bitcoin Core 28.1 was released alongside 29.0. Bitcoin Core 28.3 was released in June this year and has more recent fixes backported than 29.0. ACKs for top commit: kristapsk: utACK b4e3fdd Tree-SHA512: c4d4c4c09156e01667c87d0e0b5815c3106530363e7d2d2e3a015538520a6c6aeeef28edfd3aeb5ee40c6f0c879d81fb64daa244b8148c32da570b8439c917e5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not recommend anything older, there have been vulnerabilty fix. https://bitcoincore.org/en/2025/04/28/disclose-cve-2024-52919/