Skip to content

Commit 5246c1c

Browse files
committed
Merge #1817: Update minimum supported Bitcoin Core version to 28.1
b4e3fdd Update minimum supported Bitcoin Core version to 28.1 (3np) Pull request description: Drop minimum supported Bitcoin Core version from 29.0 to 28.1. Minimum version was lifted in #1782. The motivating bitcoin-core issue was patched in 28.1. Bitcoin Core 28.1 was released alongside 29.0. Bitcoin Core 28.3 was released in June this year and has more recent fixes backported than 29.0. ACKs for top commit: kristapsk: utACK b4e3fdd Tree-SHA512: c4d4c4c09156e01667c87d0e0b5815c3106530363e7d2d2e3a015538520a6c6aeeef28edfd3aeb5ee40c6f0c879d81fb64daa244b8148c32da570b8439c917e5
2 parents 94660e7 + b4e3fdd commit 5246c1c

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

.github/workflows/unittests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
matrix:
1111
os: [macos-13, ubuntu-latest]
1212
python-version: ["3.9", "3.12"]
13-
bitcoind-version: ["29.2"]
13+
bitcoind-version: ["28.3", "29.2"]
1414

1515
steps:
1616
- uses: actions/checkout@v3

docs/INSTALL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ If (a), then note the following two points:
136136
137137
##### Installing Bitcoin Core
138138
139-
If you haven't done so yet, install Bitcoin Core, version 29.0 or newer, as described [here](https://bitcoin.org/en/full-node#windows-10). After starting it for the first time, it will start the Initial Block Download. JoinMarket cannot be used until this is finished. More information on that can be found [here](https://bitcoin.org/en/full-node#initial-block-downloadibd).
139+
If you haven't done so yet, install Bitcoin Core, version 28.1 or newer, as described [here](https://bitcoin.org/en/full-node#windows-10). After starting it for the first time, it will start the Initial Block Download. JoinMarket cannot be used until this is finished. More information on that can be found [here](https://bitcoin.org/en/full-node#initial-block-downloadibd).
140140
141141
##### Configuring Bitcoin Core
142142

docs/PAYJOIN.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ So just skip those sections if you already know it.
3939

4040
### Preparatory step: configuring for Bitcoin Core.
4141

42-
Joinmarket currently requires a Bitcoin Core full node, version 29.0 or newer, although it can be pruned.
42+
Joinmarket currently requires a Bitcoin Core full node, version 28.1 or newer, although it can be pruned.
4343

4444
First thing to do: in `scripts/`, run:
4545

docs/TESTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
### Test instructions (for developers):
22

3-
Work in your `jmvenv` virtual environment as for all Joinmarket work. Make sure to have [bitcoind](https://bitcoin.org/en/full-node) 29.0 or newer installed. Also need miniircd installed to the root (i.e. in your `joinmarket-clientserver` directory):
3+
Work in your `jmvenv` virtual environment as for all Joinmarket work. Make sure to have [bitcoind](https://bitcoin.org/en/full-node) 28.1 or newer installed. Also need miniircd installed to the root (i.e. in your `joinmarket-clientserver` directory):
44

55
(jmvenv)$ cd /path/to/joinmarket-clientserver
66
(jmvenv)$ git clone https://github.com/Joinmarket-Org/miniircd

0 commit comments

Comments
 (0)