Conversation
Floating medians and linetype tests still need fixing (failing tests)
…new long data format.
Remove warning suppression from plotting
- modularise x-axis formatting - additional comments - indentation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the visualisation code to use long data instead of wide. This in conjunction with use of the package
ggnewscaleenables moving away from using thealphaaesthetic ofggplot2in delineating period types, in favour of thecolouraesthetic. In turn this enables removal of the use of warning suppression.Furthermore, this enables a slight simplification of the linetype tests.
Closes #64, closes #65