Fix issue with missing control limits for length-1 display periods.#221
Merged
Fix issue with missing control limits for length-1 display periods.#221
Conversation
Also update linetype tests to work with this fix.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Also sort data before returning
Owner
Author
|
@derrynlovett I took a look at #210 as it was not resolved by PR #220. Would you be happy to review my suggested fix here? |
derrynlovett
approved these changes
Jan 28, 2026
Collaborator
derrynlovett
left a comment
derrynlovett
left a comment
There was a problem hiding this comment.
Happy to approve this Tom. No comments on the added code. Looks like a good solution that fixes the issue.
Owner
Author
Great, thanks @derrynlovett - I will merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #210
Also updates linetype tests to work with this fix.