More carefully cache transaction logs when we do not (yet) have acces…#400
Closed
More carefully cache transaction logs when we do not (yet) have acces…#400
Conversation
DavidCockerill
approved these changes
Apr 23, 2026
cb1kenobi
approved these changes
Apr 24, 2026
| } | ||
| this.updates++; | ||
| this.logByName.set(logName, log); | ||
| return nodeId; |
Contributor
There was a problem hiding this comment.
ensureLogExists() returns return this.addLogToMaps(log);, so removing this could potentially affect whatever calls ensureLogExists()... which currently looks like nothing. 🙃
Consider either reverting this or update ensureLogExists() to not explicitly return a value;.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s node ids