Skip to content

Move nodeIdMapping from pro version to core#403

Merged
kriszyp merged 3 commits intov5.0from
move-nodeIdMapping
Apr 24, 2026
Merged

Move nodeIdMapping from pro version to core#403
kriszyp merged 3 commits intov5.0from
move-nodeIdMapping

Conversation

@kriszyp
Copy link
Copy Markdown
Member

@kriszyp kriszyp commented Apr 24, 2026

No description provided.

@kriszyp
Copy link
Copy Markdown
Member Author

kriszyp commented Apr 24, 2026

I tried eagerly loading replication HarperFast/harper-pro@6fffc73, but that failed (https://github.com/HarperFast/harper-pro/actions/runs/24856733779)
I tried to updated transaction log caching to avoid caching until getRemoteNodeId is available: #400
But that seems rather complicated and weird that we have special logic before a dependency is loaded and there are ids that can't be mapped until it is loaded.
This PR moves the nodeIdMapping.ts module into core, where it is really already pretty heavily used. Which I think is a little more sensible solution.

@kriszyp kriszyp marked this pull request as ready for review April 24, 2026 10:29
@kriszyp kriszyp requested a review from a team as a code owner April 24, 2026 10:29
@cb1kenobi
Copy link
Copy Markdown
Contributor

LGTM!

@kriszyp kriszyp merged commit 042b999 into v5.0 Apr 24, 2026
22 of 25 checks passed
@kriszyp kriszyp deleted the move-nodeIdMapping branch April 24, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants