Skip to content

support HARPER_CLI_* env vars #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ldt1996 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

support HARPER_CLI_* env vars #391

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c41768c
accept HARPER_CLI_TARGET as alias for CLI_TARGET
ldt1996 Apr 21, 2026
a0d3366
support HARPER_CLI_* env vars
ldt1996 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bin/cliOperations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ function buildRequest() {
*/
async function cliOperations(req) {
if (!req.target) {
req.target = process.env.CLI_TARGET;
req.target = process.env.CLI_TARGET || process.env.HARPER_CLI_TARGET;
Copy link
Copy Markdown
Contributor

@cb1kenobi cb1kenobi Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these HARPER_CLI_* env vars? Why aren't the CLI_TARGET* env vars sufficient?

Copy link
Copy Markdown
Contributor Author

@ldt1996 ldt1996 Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It began with a user setting HARPER_CLI_TARGET in a GH Actions workflow. We discussed on the slack thread, and Kris confirmed we want to move toward HARPER_-prefixed env vars

Copy link
Copy Markdown
Contributor

@cb1kenobi cb1kenobi Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K, just checking. We should add a ticket these new env vars.

}
let target;
if (req.target) {
Expand All @@ -73,15 +73,15 @@ async function cliOperations(req) {
try {
target = new URL(`https://${req.target}:9925`);
} catch {
throw error; // throw the original error
throw error;
}
}
target = {
protocol: target.protocol,
hostname: target.hostname,
port: target.port,
username: req.username || target.username || process.env.CLI_TARGET_USERNAME,
password: req.password || target.password || process.env.CLI_TARGET_PASSWORD,
username: req.username || target.username || process.env.CLI_TARGET_USERNAME || process.env.HARPER_CLI_USERNAME,
password: req.password || target.password || process.env.CLI_TARGET_PASSWORD || process.env.HARPER_CLI_PASSWORD,
rejectUnauthorized: req.rejectUnauthorized,
};
} else {
Expand Down
Loading