Open
Conversation
cb1kenobi
reviewed
Apr 21, 2026
| async function cliOperations(req) { | ||
| if (!req.target) { | ||
| req.target = process.env.CLI_TARGET; | ||
| req.target = process.env.CLI_TARGET || process.env.HARPER_CLI_TARGET; |
Contributor
There was a problem hiding this comment.
What are these HARPER_CLI_* env vars? Why aren't the CLI_TARGET* env vars sufficient?
Contributor
Author
There was a problem hiding this comment.
It began with a user setting HARPER_CLI_TARGET in a GH Actions workflow. We discussed on the slack thread, and Kris confirmed we want to move toward HARPER_-prefixed env vars
Contributor
There was a problem hiding this comment.
K, just checking. We should add a ticket these new env vars.
ldt1996
changed the title
HARPER_CLI_TARGET as alias for CLI_TARGET
cb1kenobi
approved these changes
Apr 21, 2026
kriszyp
approved these changes
Apr 22, 2026
Member
kriszyp
left a comment
kriszyp
left a comment
There was a problem hiding this comment.
This is good, but were you going to add some logging to indicate if the CLI was connecting to local vs a target?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE:
After some discussions, the agreement is that we'll prefer
HARPER_prefixed env vars , but we accept both versionsfixes
HdbError: Harper properties file at path /Users/lavinia/.nvm/versions/node/v24.14.1/lib/node_modules/harper/dist/hdb_boot_properties.file does not exist