Skip to content

feat(Spanner): integrate SourceConfigParser to centralize shard configuration loading for SourceDbToSpanner pipelines.#3854

Draft
pratickchokhani wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
pratickchokhani:shard-config-bulk
Draft

feat(Spanner): integrate SourceConfigParser to centralize shard configuration loading for SourceDbToSpanner pipelines.#3854
pratickchokhani wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
pratickchokhani:shard-config-bulk

Conversation

@pratickchokhani
Copy link
Copy Markdown
Contributor

No description provided.

1. Implemented a source config parser.
2. Parser returns abstract SourceConnectionConfig.
3. SourceConnectionConfig is dependent on the source type.
4. For JDBC the password is resolved using secret manager.
…guration loading for SourceDbToSpanner pipelines
@pratickchokhani pratickchokhani added the addition New feature or request label May 25, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 82.35294% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.96%. Comparing base (f66b280) to head (453a9f9).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...loud/teleport/v2/templates/PipelineController.java 11.76% 15 Missing ⚠️
...cloud/teleport/v2/templates/SourceDbToSpanner.java 0.00% 5 Missing ⚠️
...r/migrations/source/config/SourceConfigParser.java 89.36% 2 Missing and 3 partials ⚠️
...ud/teleport/v2/options/OptionsToConfigBuilder.java 92.30% 1 Missing ⚠️
...tions/source/config/CassandraConnectionConfig.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3854      +/-   ##
============================================
+ Coverage     54.96%   62.96%   +7.99%     
+ Complexity     6925     2264    -4661     
============================================
  Files          1096      513     -583     
  Lines         67353    29944   -37409     
  Branches       7558     3298    -4260     
============================================
- Hits          37021    18854   -18167     
+ Misses        27857    10098   -17759     
+ Partials       2475      992    -1483     
Components Coverage Δ
spanner-templates 79.59% <82.35%> (+4.78%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 90.15% <94.91%> (+2.76%) ⬆️
spanner-live-reverse-replication 82.78% <94.91%> (+3.98%) ⬆️
spanner-bulk-migration 92.34% <82.35%> (+1.37%) ⬆️
gcs-spanner-dv 90.38% <94.91%> (+4.63%) ⬆️
Files with missing lines Coverage Δ
...ud/teleport/v2/spanner/migrations/shard/Shard.java 83.58% <100.00%> (+5.99%) ⬆️
...igrations/source/config/AstraConnectionConfig.java 100.00% <100.00%> (ø)
...nner/migrations/source/config/JdbcShardConfig.java 100.00% <100.00%> (ø)
...2/spanner/migrations/source/config/SourceType.java 100.00% <100.00%> (ø)
...er/migrations/utils/SecretManagerAccessorImpl.java 95.00% <100.00%> (+45.00%) ⬆️
...t/v2/spanner/migrations/utils/ShardFileReader.java 86.84% <100.00%> (-2.05%) ⬇️
...ud/teleport/v2/options/OptionsToConfigBuilder.java 89.25% <92.30%> (-4.87%) ⬇️
...tions/source/config/CassandraConnectionConfig.java 75.00% <75.00%> (ø)
...cloud/teleport/v2/templates/SourceDbToSpanner.java 37.14% <0.00%> (+1.03%) ⬆️
...r/migrations/source/config/SourceConfigParser.java 89.36% <89.36%> (ø)
... and 1 more

... and 625 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant