minor refactoring.

Author: pratickchokhani

v2/sourcedb-to-spanner/src/main/java/com/google/cloud/teleport/v2/templates/SourceDbToSpanner.java

@@ -93,6 +93,30 @@ protected static SourceDbToSpannerOptions getSourceDbToSpannerOptions(String[] a
     return options;
   }
 
+  /**
+   * Validates the provided pipeline options. TODO: move this to source connector.
+   *
+   * @param options The execution parameters to the pipeline.
+   * @param sourceConnectionConfig Parsed source connection config.
+   * @throws IllegalArgumentException if the provided options are invalid for the pipeline.
+   */
+  @VisibleForTesting
+  static void validateOptions(
+      SourceDbToSpannerOptions options, SourceConnectionConfig sourceConnectionConfig) {
+    if (SourceDbToSpannerOptions.PG_SOURCE_DIALECT.equals(options.getSourceDbDialect())) {
+      Preconditions.checkArgument(
+          (sourceConnectionConfig instanceof JdbcShardConfig),
+          "Postgresql dialect should have JDBC source config.");
+      for (Shard shard : ((JdbcShardConfig) sourceConnectionConfig).getShardConfigs()) {
+        if (StringUtils.isNotBlank(shard.getNamespace())
+            && !shard.getNamespace().equals("public")) {
+          throw new IllegalArgumentException(
+              "Non-public namespaces are currently unsupported for PostgreSQL migrations.");
+        }
+      }
+    }
+  }
+
   /**
    * Create the pipeline with the supplied options.
    *
@@ -132,28 +156,4 @@ static SpannerConfig createSpannerConfig(SourceDbToSpannerOptions options) {
     }
     return spannerConfig;
   }
-
-  /**
-   * Validates the provided pipeline options.
-   *
-   * @param options The execution parameters to the pipeline.
-   * @param sourceConnectionConfig Parsed source connection config.
-   * @throws IllegalArgumentException if the provided options are invalid for the pipeline.
-   */
-  @VisibleForTesting
-  static void validateOptions(
-      SourceDbToSpannerOptions options, SourceConnectionConfig sourceConnectionConfig) {
-    if (SourceDbToSpannerOptions.PG_SOURCE_DIALECT.equals(options.getSourceDbDialect())) {
-      Preconditions.checkArgument(
-          (sourceConnectionConfig instanceof JdbcShardConfig),
-          "Postgresql dialect should have JDBC source config.");
-      for (Shard shard : ((JdbcShardConfig) sourceConnectionConfig).getShardConfigs()) {
-        if (StringUtils.isNotBlank(shard.getNamespace())
-            && !shard.getNamespace().equals("public")) {
-          throw new IllegalArgumentException(
-              "Non-public namespaces are currently unsupported for PostgreSQL migrations.");
-        }
-      }
-    }
-  }
 }

v2/sourcedb-to-spanner/src/test/java/com/google/cloud/teleport/v2/source/cassandra/reader/io/cassandra/iowrapper/CassandraIOWrapperFactoryTest.java

@@ -60,8 +60,6 @@
 @RunWith(MockitoJUnitRunner.class)
 public class CassandraIOWrapperFactoryTest {
   private MockedStatic<CassandraIOWrapperHelper> mockCassandraIoWrapperHelper;
-  private static final String TEST_BUCKET_CASSANDRA_CONFIG_CONF =
-      "gs://smt-test-bucket/cassandraConfig.conf";
   private static final ImmutableList<String> TABLES_TO_READ =
       ImmutableList.of(BASIC_TEST_TABLE, PRIMITIVE_TYPES_TABLE);
   @Mock SourceSchema mockSourceSchema;