Skip to content

TEST: for reproducing an issue with value set on outside click #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rreckonerr wants to merge 1 commit into from
Closed

TEST: for reproducing an issue with value set on outside click #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions test-app/tests/integration/components/combobox-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,54 @@ module('Integration | Component | <Combobox>', function (hooks) {

assert.dom(getComboboxInput()).hasValue('B');
});

test('selecting an option puts the display value into Combobox.Input when displayValue is provided and values are objects', async function (assert) {
this.set('onChange', (value) => {
this.set('value', value);
});

this.setProperties({
value: null,
a: { value: 'a' },
b: { value: 'b' },
c: { value: 'c' },
displayValue: (option) => {
return option?.value?.toUpperCase() || 'None';
},
});

await render(hbs`
<Combobox
@value={{this.value}}
@onChange={{this.onChange}}
as |combobox|
>
<combobox.Input @displayValue={{this.displayValue}}/>
<combobox.Button data-test="headlessui-combobox-button-2">Trigger</combobox.Button>
<combobox.Options as |options|>
<options.Option @value={{this.a}}>Option A</options.Option>
<options.Option @value={{this.b}}>Option B</options.Option>
<options.Option @value={{this.c}}>Option C</options.Option>
</combobox.Options>
</Combobox>
`);

await click(getComboboxButton());
assertComboboxList({ state: ComboboxState.Visible });

await click(getComboboxOptions()[1]);
assert.dom(getComboboxInput()).hasValue('B');

await click(getComboboxButton());
assertComboboxList({ state: ComboboxState.Visible });

assert.dom(getComboboxInput()).hasValue('B');

await click(document.body);
assertComboboxList({ state: ComboboxState.InvisibleUnmounted });

assert.dom(getComboboxInput()).hasValue('B');
});
});

module('Combobox.Label', () => {
Expand Down