TEST: for reproducing an issue with value set on outside click#189
Closed
rreckonerr wants to merge 1 commit into
Closed
TEST: for reproducing an issue with value set on outside click#189rreckonerr wants to merge 1 commit into
rreckonerr wants to merge 1 commit into
Conversation
GavinJoyce
added a commit
that referenced
this pull request
Dec 20, 2025
Swap order in handleOptionClick to call onChange before setSelectedOption, so this.args.value is already updated when setSelectedOption runs. Also set inputValue to immediately reflect the selection. Includes test from PR #189.
GavinJoyce
added a commit
that referenced
this pull request
Dec 20, 2025
Fixes #188 - Combobox now correctly preserves selected values when clicking outside after selecting a non-primitive option. Root cause: In handleOptionClick, setSelectedOption was called before onChange, so this.args.value hadn't been updated yet. Changes: - Swap order in -option.js: call onChange first, then setSelectedOption - Set inputValue in setSelectedOption so input immediately reflects selection - Add test from PR #189 for non-primitive values with displayValue
Owner
|
rolled into #193, thanks |
Contributor
Author
|
Thanks for looking into it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #188