Skip to content

Antithesis intake port#1826

Draft
blt wants to merge 1 commit into
blt/antithesis-workload-samplingfrom
blt/antithesis_intake_port
Draft

Antithesis intake port#1826
blt wants to merge 1 commit into
blt/antithesis-workload-samplingfrom
blt/antithesis_intake_port

Conversation

@blt
Copy link
Copy Markdown
Contributor

@blt blt commented Jun 5, 2026

Summary

Rough port from a private line of work, not ready to review yet.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

References

Copy link
Copy Markdown
Contributor Author

blt commented Jun 5, 2026

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1-2 Bot commented Jun 5, 2026

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

DataDog/saluki | check-unused-deps   View in Datadog   GitLab

DataDog/saluki | unit-tests-windows-amd64   View in Datadog   GitLab

Semantic PR Title Check | Check For Semantic PR Title   View in Datadog   GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a6287d2 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 5, 2026

Binary Size Analysis (Agent Data Plane)

Baseline: d93575e · Comparison: a6287d2 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 38.10 MiB (baseline) vs 38.00 MiB (comparison)
Size Change: -106.66 KiB (-0.27%)

✅ Binary size difference within threshold

Changes by Module
Module File Size Symbols
core +30.83 KiB 1936
prost -30.63 KiB 98
figment -29.26 KiB 220
tokio -12.38 KiB 656
tonic -9.36 KiB 184
h2 +8.46 KiB 83
hyper -7.61 KiB 165
alloc +7.37 KiB 704
anyhow -6.00 KiB 358
agent_data_plane::cli::run -5.93 KiB 10
[sections] -5.52 KiB 7
rustls -4.49 KiB 185
http_body_util -4.33 KiB 37
[Unmapped] +4.32 KiB 1
anon.b1989804c321c6229c83a9d121c3ffb0.48.llvm.15956482214170139656 +4.00 KiB 1
anon.ae75cd3060d8b952a6fd466cba97c1c5.103.llvm.298110800033293764 -3.91 KiB 1
agent_data_plane::components::ottl_transform_processor -3.67 KiB 9
serde_yaml -3.61 KiB 44
tower -3.60 KiB 113
serde_core -3.23 KiB 82
Detailed Symbol Changes
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW] +5.59Ki  [NEW]    +359    core::ptr::drop_in_place<http_body_util::combinators::map_err::MapErr<http_body_util::combinators::map_err::MapErr<http_body_util::combinators::map_frame::MapFrame<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic::codec::decode::Streaming<datadog_protos::agent_include::datadog::remoteagent::v1::RefreshRemoteAgentResponse>::new<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic_prost::codec::ProstDecoder<datadog_protos::agent_include::datadog::remoteagent::v1::RefreshRemoteAgentResponse>>::{{closure}}>,tonic::codec::decode::Streaming<datadog_protos::agent_include::datadog::remoteagent::v1::RefreshRemoteAgentResponse>::new<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic_prost::codec::ProstDecoder<datadog_protos::agent_include::datadog::remoteagent::v1::RefreshRemoteAgentResponse>>::{{closure}}>,tonic::status::Status::map_error<tonic::status::S
  [NEW] +5.44Ki  [NEW] +5.29Ki    _<figment::value::magic::RelativePathBuf as figment::value::magic::Magic>::deserialize_from::hcfd625ee9333661b
  [NEW] +5.19Ki  [NEW] +4.89Ki    alloc::collections::btree::node::Handle<alloc::collections::btree::node::NodeRef<alloc::collections::btree::node::marker::Mut,K,V,alloc::collections::btree::node::marker::Leaf>,alloc::collections::btree::node::marker::Edge>::insert_recursing::h5a7d8ef71dfe1d76
  [NEW] +5.02Ki  [NEW]    +359    core::ptr::drop_in_place<http_body_util::combinators::map_err::MapErr<http_body_util::combinators::map_frame::MapFrame<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic::codec::decode::Streaming<datadog_protos::agent_include::datadog::model::v1::HostTagReply>::new<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic_prost::codec::ProstDecoder<datadog_protos::agent_include::datadog::model::v1::HostTagReply>>::{{closure}}>,tonic::codec::decode::Streaming<datadog_protos::agent_include::datadog::model::v1::HostTagReply>::new<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic_prost::codec::ProstDecoder<datadog_protos::agent_include::datadog::model::v1::HostTagReply>>::{{closure}}>>::hb8a4232a81af1918
  [NEW] +5.00Ki  [NEW] +4.70Ki    alloc::collections::btree::node::Handle<alloc::collections::btree::node::NodeRef<alloc::collections::btree::node::marker::Mut,K,V,alloc::collections::btree::node::marker::Leaf>,alloc::collections::btree::node::marker::Edge>::insert_recursing::h0fe2dbb6a6a94df1
  [NEW] +4.99Ki  [NEW] +4.84Ki    _<figment::value::magic::Tagged<T> as figment::value::magic::Magic>::deserialize_from::he774f97a97ff55b1
  +9.2% +4.92Ki  +9.3% +4.92Ki    saluki_core::topology::blueprint::TopologyBlueprint::build::_{{closure}}::hbf871b3913e42c66
  [NEW] +4.83Ki  [NEW] +4.58Ki    agent_data_plane::components::ottl_filter_processor::config::_::_<impl serde_core::de::Deserialize for agent_data_plane::components::ottl_filter_processor::config::OttlFilterConfig>::deserialize::h4f4429612e2653e9
  [NEW] +4.77Ki  [NEW] +4.47Ki    alloc::collections::btree::node::Handle<alloc::collections::btree::node::NodeRef<alloc::collections::btree::node::marker::Mut,K,V,alloc::collections::btree::node::marker::Leaf>,alloc::collections::btree::node::marker::Edge>::insert_recursing::h859019f427a7299f
  [NEW] +4.74Ki  [NEW] +4.58Ki    _<figment::value::de::ConfiguredValueDe<I> as serde_core::de::Deserializer>::deserialize_struct::ha66bb36cad767a6d
  [NEW] +4.52Ki  [NEW] +4.22Ki    alloc::collections::btree::node::Handle<alloc::collections::btree::node::NodeRef<alloc::collections::btree::node::marker::Mut,K,V,alloc::collections::btree::node::marker::Leaf>,alloc::collections::btree::node::marker::Edge>::insert_recursing::hea023ce38d3adc08
  [DEL] -4.78Ki  [DEL] -4.62Ki    _<figment::value::de::ConfiguredValueDe<I> as serde_core::de::Deserializer>::deserialize_struct::h7a39627207e3f3a4
  [DEL] -4.80Ki  [DEL] -4.64Ki    _<figment::value::magic::RelativePathBuf as figment::value::magic::Magic>::deserialize_from::h6ff9f06009392c01
  [DEL] -4.85Ki  [DEL] -4.59Ki    agent_data_plane::components::ottl_transform_processor::config::_::_<impl serde_core::de::Deserialize for agent_data_plane::components::ottl_transform_processor::config::OttlTransformConfig>::deserialize::hc55bc685ff741938
  [DEL] -5.12Ki  [DEL] -5.01Ki    alloc::collections::btree::map::BTreeMap<K,V,A>::insert::hba0bacef74150a71
  -0.5% -5.12Ki  -0.5% -5.12Ki    [section .gcc_except_table]
  [DEL] -5.30Ki  [DEL]     -51    core::ptr::drop_in_place<http_body_util::combinators::map_err::MapErr<http_body_util::combinators::map_err::MapErr<http_body_util::combinators::map_frame::MapFrame<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic::codec::decode::Streaming<datadog_protos::agent_include::datadog::model::v1::HostTagReply>::new<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic_prost::codec::ProstDecoder<datadog_protos::agent_include::datadog::model::v1::HostTagReply>>::{{closure}}>,tonic::codec::decode::Streaming<datadog_protos::agent_include::datadog::model::v1::HostTagReply>::new<tonic::service::interceptor::ResponseBody<tonic::body::Body>,tonic_prost::codec::ProstDecoder<datadog_protos::agent_include::datadog::model::v1::HostTagReply>>::{{closure}}>,tonic::status::Status::map_error<tonic::status::Status>>>::h7c1e60183b87d306
  [DEL] -5.38Ki  [DEL] -5.23Ki    _<figment::value::magic::Tagged<T> as figment::value::magic::Magic>::deserialize_from::h4482918f844c4c1b
  [DEL] -5.73Ki  [DEL] -5.58Ki    _<figment::value::magic::RelativePathBuf as figment::value::magic::Magic>::deserialize_from::hd72d65f5176e7f06
  -4.1% -6.16Ki  -4.1% -6.16Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::h0215ea3520b410a0
  -0.9%  -114Ki  -1.3%  -130Ki    [12905 Others]
  -0.3%  -106Ki  -0.4%  -128Ki    TOTAL

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 5, 2026

Regression Detector (Agent Data Plane)

Run ID: 0923beda-a506-468f-bd40-dfb8a6f129d8
Baseline: d93575ee · Comparison: a6287d29 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (35)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment goal Δ mean % links
dsd_uds_512kb_3k_contexts_cpu (erratic) cpu ⚪ +3.47 metrics profiles logs
dsd_uds_1mb_3k_contexts_cpu (erratic) cpu ⚪ +2.36 metrics profiles logs
otlp_ingest_logs_5mb_cpu (ignored) cpu ⚪ +2.35 metrics profiles logs
otlp_ingest_logs_5mb_memory (ignored) memory ⚪ +2.02 metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_cpu (erratic) cpu ⚪ +0.81 metrics profiles logs
dsd_uds_100mb_3k_contexts_cpu (erratic) cpu ⚪ +0.60 metrics profiles logs
dsd_uds_500mb_3k_contexts_throughput throughput ⚪ -0.59 metrics profiles logs
otlp_ingest_traces_5mb_throughput throughput ⚪ -0.21 metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_throughput throughput ⚪ -0.18 metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_throughput throughput ⚪ -0.03 metrics profiles logs
otlp_ingest_metrics_5mb_cpu (erratic) cpu ⚪ +0.02 metrics profiles logs
dsd_uds_10mb_3k_contexts_throughput throughput ⚪ -0.01 metrics profiles logs
otlp_ingest_logs_5mb_throughput (ignored) throughput ⚪ -0.01 metrics profiles logs
dsd_uds_512kb_3k_contexts_throughput throughput ⚪ -0.00 metrics profiles logs
dsd_uds_100mb_3k_contexts_throughput throughput ⚪ -0.00 metrics profiles logs
dsd_uds_1mb_3k_contexts_throughput throughput ⚪ +0.00 metrics profiles logs
otlp_ingest_metrics_5mb_throughput throughput ⚪ +0.01 metrics profiles logs
otlp_ingest_traces_5mb_memory memory ⚪ -0.06 metrics profiles logs
quality_gates_rss_dsd_medium memory ⚪ -0.15 metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory ⚪ -0.15 metrics profiles logs
dsd_uds_500mb_3k_contexts_cpu (erratic) cpu ⚪ -0.20 metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_memory memory ⚪ -0.21 metrics profiles logs
dsd_uds_100mb_3k_contexts_memory memory ⚪ -0.47 metrics profiles logs
quality_gates_rss_dsd_heavy memory ⚪ -0.48 metrics profiles logs
quality_gates_rss_dsd_low memory ⚪ -0.49 metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_memory memory ⚪ -0.53 metrics profiles logs
dsd_uds_500mb_3k_contexts_memory memory ⚪ -0.57 metrics profiles logs
dsd_uds_512kb_3k_contexts_memory memory ⚪ -0.87 metrics profiles logs
dsd_uds_1mb_3k_contexts_memory memory ⚪ -0.91 metrics profiles logs
quality_gates_rss_idle memory ⚪ -0.95 metrics profiles logs
dsd_uds_10mb_3k_contexts_memory memory ⚪ -1.06 metrics profiles logs
otlp_ingest_metrics_5mb_memory memory ⚪ -1.19 metrics profiles logs
otlp_ingest_traces_5mb_cpu (erratic) cpu ⚪ -1.55 metrics profiles logs
dsd_uds_10mb_3k_contexts_cpu (erratic) cpu ⚪ -2.96 metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_cpu (erratic) cpu ⚪ -3.27 metrics profiles logs
Bounds Checks: ✅ Passed (5)
experiment check replicates observed links
quality_gates_rss_dsd_heavy memory_usage 10/10 ✅ 116 MiB ≤ 140 MiB metrics profiles logs
quality_gates_rss_dsd_low memory_usage 10/10 ✅ 39.8 MiB ≤ 50 MiB metrics profiles logs
quality_gates_rss_dsd_medium memory_usage 10/10 ✅ 60.3 MiB ≤ 75 MiB metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 ✅ 181 MiB ≤ 200 MiB metrics profiles logs
quality_gates_rss_idle memory_usage 10/10 ✅ 26.9 MiB ≤ 40 MiB metrics profiles logs
Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test All things testing: unit/integration, correctness, SMP regression, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant