enhancement(antithesis): Vary datadog.yaml in test/antithesis, assert aliveness#1779
Conversation
This comment has been minimized.
This comment has been minimized.
a372743 to
dc9a86b
Compare
Binary Size Analysis (Agent Data Plane)Baseline: ba3b71f · Comparison: 6577832 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
dc9a86b to
a152801
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a15280185c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3952ec9 to
e540987
Compare
a152801 to
4fc1007
Compare
e540987 to
8d3fbbf
Compare
4fc1007 to
0f6c10e
Compare
b230025 to
1b642b8
Compare
0f6c10e to
5aaad6f
Compare
tobz
left a comment
There was a problem hiding this comment.
Seems fine to me so long as you address (or dismiss with cause) the Codex comments.
5aaad6f to
0239db1
Compare
0239db1 to
29d780c
Compare
f4d5a5a to
90f327d
Compare
This PR introduces variation in the datadog.yaml we use under test in the antithesis rig. The goal here is to explore variation in buffer sizes etc and also startup panics on truly weird configs. ADP aliveness on bootup via the way it is rigged into the compose cluster and we assert a 'sometimes' check to forwarding in datadog/io.rs. This later 'sometimes' acts as a checkpoint for antithesis, allowing it to figure that ADP has reached a nominally functional state and can be explored from that point. The antithesis setup checkpoint is done before datadog.yaml is sampled. Notable things: * first_sample_config runs after setup-checkpoint and before ADP boots, is responsible for creating datadog.yaml and other configs in the future * eventually_adp_alive is a weak check and we may drop it in the future as our coverage improves, but it doesn't hurt anything now * I introduced a harness::rand to encode antithesis-friendly sampling of large domains, this will expand over time * Skill `antithesis-research` has updated its 'scratchbook' but this is a mechanical domain for now, will later convert it to a human-hybrid material
90f327d to
6577832
Compare
… aliveness (#1779) ## Summary <!-- Please provide a brief summary about what this PR does. This should help the reviewers give feedback faster and with higher quality. --> This PR introduces variation in the datadog.yaml we use under test in the antithesis rig. The goal here is to explore variation in buffer sizes etc and also startup panics on truly weird configs. ADP aliveness on bootup via the way it is rigged into the compose cluster and we assert a 'sometimes' check to forwarding in datadog/io.rs. This later 'sometimes' acts as a checkpoint for antithesis, allowing it to figure that ADP has reached a nominally functional state and can be explored from that point. The antithesis setup checkpoint is done before datadog.yaml is sampled. Notable things: - first_sample_config runs after setup-checkpoint and before ADP boots, is responsible for creating datadog.yaml and other configs in the future - eventually_adp_alive is a weak check and we may drop it in the future as our coverage improves, but it doesn't hurt anything now - I introduced a harness::rand to encode antithesis-friendly sampling of large domains, this will expand over time - Skill `antithesis-research` has updated its 'scratchbook' but this is a mechanical domain for now, will later convert it to a human-hybrid material ## Change Type - [ ] Bug fix - [ ] New feature - [x] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR? <!-- Please how you tested these changes here --> Antithesis shots with change in place, confirmed config == timeline match. ## References N/A <!-- Please list any issues closed by this PR. --> <!-- - Closes: <issue link> --> <!-- Any other issues or PRs relevant to this PR? Feel free to list them here. --> dc62bbd

Summary
This PR introduces variation in the datadog.yaml we use under test in
the antithesis rig. The goal here is to explore variation in buffer
sizes etc and also startup panics on truly weird configs.
ADP aliveness on bootup via the way it is rigged into the compose cluster and we assert a 'sometimes' check to forwarding in datadog/io.rs. This later 'sometimes' acts as a checkpoint for antithesis, allowing it to figure that ADP has reached a nominally functional state and can be explored from that point. The antithesis setup checkpoint is done before datadog.yaml is sampled.
Notable things:
antithesis-researchhas updated its 'scratchbook' but this is a mechanical domain for now, will later convert it to a human-hybrid materialChange Type
How did you test this PR?
Antithesis shots with change in place, confirmed config == timeline match.
References
N/A