[chain-pr 5/10] DatadogLogs: typed-bus migration#2931
Draft
maxep wants to merge 3 commits into
Draft
Conversation
|
maxep
force-pushed
the
maxep/message-bus-subscription--chain-3
branch
from
ed91047 to
2469c47
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-5
branch
from
21314b1 to
ec7dc67
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-3
branch
from
2469c47 to
588136c
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-5
branch
from
ec7dc67 to
ba7bf22
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-3
branch
from
588136c to
c482945
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-5
branch
from
ba7bf22 to
a00efe9
Compare
5 tasks
maxep
force-pushed
the
maxep/message-bus-subscription--chain-3
branch
from
c482945 to
c2710e2
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-5
branch
from
a00efe9 to
935cf5e
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-3
branch
2 times, most recently
from
12483fe to
39dd976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Migrates LogMessageReceiver and WebViewLogReceiver to BusMessageReceiver, wires subscriptions in Logs.enable, threads MessageBus through RemoteLogger for RUM error forwarding, and switches global attribute change notifications to the typed bus. Updates tests and mocks.
Refactoring rationale
Logs receivers previously consumed FeatureMessage via switch/case. They now conform to BusMessageReceiver with their concrete message type, eliminating the runtime cast. RemoteLogger now uses MessageBus directly for cross-feature RUM error emission instead of FeatureScope.send.
Draft — pending author review. Merge in order unless marked parallel.