[chain-pr 7/10] DatadogFlags: typed-bus migration#2933
Draft
maxep wants to merge 5 commits into
Draft
Conversation
|
maxep
force-pushed
the
maxep/message-bus-subscription--chain-3
branch
from
ed91047 to
2469c47
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-7
branch
from
185b00a to
f54b5ec
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-3
branch
from
2469c47 to
588136c
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-7
branch
from
f54b5ec to
c97dbac
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-3
branch
from
588136c to
c482945
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-7
branch
from
c97dbac to
2f2ffbc
Compare
5 tasks
maxep
force-pushed
the
maxep/message-bus-subscription--chain-3
branch
from
c482945 to
c2710e2
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-7
branch
from
2f2ffbc to
176b9f2
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-3
branch
2 times, most recently
from
12483fe to
39dd976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Switches RUMFlagEvaluationReporter from FeatureScope to MessageBus, updates FlagsFeature factory wiring, and adapts FlagsClient and tests.
Refactoring rationale
Flag evaluation reporting moves off FeatureScope.send onto the typed MessageBus, simplifying the factory signature (no FeatureScope argument) and removing the FeatureMessage envelope from the cross-feature contract with RUM.
Draft — pending author review. Merge in order unless marked parallel.