Skip to content

set a better aria-label for logo when it is a link #15650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caolanm wants to merge 1 commit into from
+18 −2
Closed

set a better aria-label for logo when it is a link #15650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions browser/src/control/Control.Notebookbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,29 @@ window.L.Control.Notebookbar = window.L.Control.extend({
docLogo.setAttribute('id', 'document-logo');
docLogo.setAttribute('type', 'action');
docLogo.setAttribute('target', '_blank');
docLogo.setAttribute('aria-label', _('file type icon'));
docLogo.setAttribute('tabIndex', 0);
docLogo.setAttribute('aria-label', _('file type icon'));

if (iconTooltip) {
docLogo.setAttribute('data-cooltip', iconTooltip);
}
// Mirror data-cooltip onto aria-label so the accessible name
// matches the visible tooltip, even when branding overrides
// data-cooltip after load (e.g. to "Collabora Online"). When
// branding also sets an href, target="_blank" takes effect and
// the link opens a new tab, so announce that to screen readers.
const syncAriaLabel = () => {
const cooltip = docLogo.getAttribute('data-cooltip');
if (!cooltip) return;
const label = docLogo.getAttribute('href')
? _('{0} website, opens in new tab').replace('{0}', cooltip)
: cooltip;
docLogo.setAttribute('aria-label', label);
};
syncAriaLabel();
new MutationObserver(syncAriaLabel).observe(docLogo, {
attributes: true,
attributeFilter: ['data-cooltip', 'href'],
});
window.L.control.attachTooltipEventListener(docLogo, this.map);
$('.main-nav').prepend(docLogoHeader);

Expand Down
Loading