set a better aria-label for logo when it is a link#15650
Closed
set a better aria-label for logo when it is a link#15650
Conversation
branding can override this and then the aria-label is out of sync, so listen for the branding change and set a suitable aria-label if a link is set WCAG 3.2.5 asks that a change of context like opening a new tab be announced - "SOMETHING website, opens in new tab" Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I8dfb117259bbe25357d3054f1857004a15e52efd
Contributor
Author
|
lets move this to monorepo as https://gerrit.collaboraoffice.com/c/online/+/1635 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
branding can override this and then the aria-label is out of sync, so listen for the branding change and set a suitable aria-label if a link is set
WCAG 3.2.5 asks that a change of context like opening a new tab be announced
Change-Id: I8dfb117259bbe25357d3054f1857004a15e52efd
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay