Skip to content

jsdialog: fix menubutton alignment with other controls in grids #15148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caolanm wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −4
Open

jsdialog: fix menubutton alignment with other controls in grids #15148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ccfce2
jsdialog: fix menubutton alignment with other controls in grids
caolanm Mar 21, 2026
fec879f
fix unwanted line breaking of menubutton text
caolanm Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser/css/btns.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ button.jsdialog[disabled] img {

:not(.main-nav) .button-secondary,
:not(.main-nav) .button-secondary:not(.arrowbackground),
:not(.main-nav) > div:not(.toolbox) > button:not(.ui-tab):not(.ui-expander-btn):not(.ui-corner-all):not(.button-primary):not(.unobutton):not(.form-field-button):not(.col):not(.arrowbackground):not(.ui-combobox-button):not(.ui-linkbutton):not(.spinfieldbutton-up):not(.spinfieldbutton-down):not(.ui-treeview-header-button) {
:not(.main-nav) > div:not(.toolbox) > button:not(.ui-tab):not(.ui-expander-btn):not(.ui-corner-all):not(.button-primary):not(.unobutton):not(.form-field-button):not(.col):not(.arrowbackground):not(.ui-combobox-button):not(.ui-linkbutton):not(.spinfieldbutton-up):not(.spinfieldbutton-down):not(.menubutton):not(.ui-treeview-header-button) {
box-sizing: border-box;
height: 32px;
line-height: normal;
Expand Down
12 changes: 9 additions & 3 deletions browser/css/jsdialogs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1969,17 +1969,19 @@ img.context-menu-icon {
/* menu button */
.jsdialog.menubutton {
box-sizing: border-box;
height: 32px;
line-height: normal;
font-size: calc(var(--default-font-size)*1.2);
width: max-content;
font-size: var(--default-font-size);
Copy link
Copy Markdown
Contributor

@pedropintosilva pedropintosilva Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a change of font-size here seems better, but I don't know who added the previous value and if there was any magic reason behind it.

font-family: var(--cool-font);
border: 1px solid var(--color-border-dark);
border-radius: var(--border-radius);
padding: 8px 10px;
padding: 0 10px;
margin: 2px 0px;
background-color: var(--color-background-dark);
display: flex;
align-items: center;
justify-content: center;
justify-content: flex-start;
}

.jsdialog.menubutton img {
Expand Down Expand Up @@ -2011,6 +2013,10 @@ button.has-img img {
margin: 5px 0 0 5px;
}

.jsdialog.menubutton .arrow {
margin-inline-start: auto;
}

.jsdialog.menubutton[disabled] {
background-color: transparent !important;
color: var(--color-text-lighter) !important;
Expand Down
19 changes: 19 additions & 0 deletions cypress_test/integration_tests/desktop/writer/spinfield_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,4 +288,23 @@ describe(['tagdesktop'], 'Spinfield unit and button tests', function () {
});
});
});

it('Menubutton and listbox-container left-align in grid', function () {
openDialogAndSwitchToBorder();

// The Line section of the Border tab has a menubutton (#linestylelb)
// and a listbox-container (#linewidthlb) in the same grid column.
// They should share the same left edge.
cy.cGet('#linestylelb').should('be.visible');
cy.cGet('#linewidthlb').should('be.visible');

cy.cGet('#linestylelb').then(function ($btn) {
var btnLeft = $btn[0].getBoundingClientRect().left;

cy.cGet('#linewidthlb').should(function ($list) {
var listLeft = $list[0].getBoundingClientRect().left;
expect(listLeft).to.equal(btnLeft);
});
});
});
});
Loading