jsdialog: fix menubutton alignment with other controls in grids#15148
Open
jsdialog: fix menubutton alignment with other controls in grids#15148
Conversation
Contributor
|
This fixes the alignment of the color boxes in the sparkline dialog too, good. However, the text seems to have a fixed width now - longer text should expand the widget, not break into multiple lines. 
|
caolanm
force-pushed
the
private/caolan/align_menubuttons_and_comboboxes
branch
from
d3c5cb5 to
8bc5982
Compare
Contributor
Author
|
That new commit solves the text wrapping issue I believe |
Contributor
|
Looks good now, thanks! |
caolanm
force-pushed
the
private/caolan/align_menubuttons_and_comboboxes
branch
3 times, most recently
from
d604aff to
e56e6e6
Compare
pedropintosilva
approved these changes
Apr 26, 2026
Contributor
pedropintosilva
left a comment
pedropintosilva
left a comment
There was a problem hiding this comment.
This also fixed the disable status:
Before
after
The broad button selector in btns.css matched jsdialog menubuttons, overriding their margin and width. This caused menubuttons to be offset by 5px from comboboxes and listboxes in the same grid column, since those are div elements that do not match the btns.css selector. Exclude .menubutton from the btns.css catch-all so menubuttons only get their jsdialogs.css styling. Also fix the menubutton rule to use the standard control height (32px), font size, and padding to match other controls, start-align the content, and push the dropdown arrow to the end of the button. Add a regression test that asserts the menubutton and listbox-container share the same left edge in the Border tab of the Character dialog. Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I3ca1a8c46f905f849d08d087f79ad940d8e2ee57
since the menubutton was removed from the catch-all rule that was disrupting their margin and width Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I89df97cf397af9922610faf06bd130b1011a013e
pedropintosilva
force-pushed
the
private/caolan/align_menubuttons_and_comboboxes
branch
from
e56e6e6 to
fec879f
Compare
Contributor
|
conflicts solved |
| line-height: normal; | ||
| font-size: calc(var(--default-font-size)*1.2); | ||
| width: max-content; | ||
| font-size: var(--default-font-size); |
Contributor
There was a problem hiding this comment.
There is a change of font-size here seems better, but I don't know who added the previous value and if there was any magic reason behind it.
Contributor
pedropintosilva
left a comment
pedropintosilva
left a comment
There was a problem hiding this comment.
probably some visual tests (the ones with image diff) need adjusting? such as desktop/impress/sidebar_spec.js:39 see baseline image esktop/impress/sidebar_spec.js/sidebar_menubutton_color.png .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broad button selector in btns.css matched jsdialog menubuttons, overriding their margin and width. This caused menubuttons to be offset by 5px from comboboxes and listboxes in the same grid column, since those are div elements that do not match the btns.css selector.
Exclude .menubutton from the btns.css catch-all so menubuttons only get their jsdialogs.css styling. Also fix the menubutton rule to use the standard control height (32px), font size, and padding to match other controls, start-align the content, and push the dropdown arrow to the end of the button.
Add a regression test that asserts the menubutton and listbox-container share the same left edge in the Border tab of the Character dialog.
Change-Id: I3ca1a8c46f905f849d08d087f79ad940d8e2ee57
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay