Slack notification after 30min of scraping#51
Open
andela-ookoro wants to merge 2 commits into
Open
Conversation
| import random | ||
| scraper_id = random.randint(1, 100000) | ||
| error['MESSAGE'] = 'Scraper: {} is taking more than 30 minutes'.format(scraper_id) | ||
| scraper.print_error(error) |
Contributor
There was a problem hiding this comment.
Because it isn't exactly an error, let's have this as a warning instead.
Contributor
Author
There was a problem hiding this comment.
Yea, I have change the log level to warning.
Contributor
|
Has this been tested on Morph.io? |
Contributor
Author
|
I did not test this feature on Morph.io, I tested it using slack_log_handler. |
Contributor
|
So the scraper works on Morph.io so definitely should be tested there to ensure compatibility. Once done, send me a link to your Morph implementation. |
andela-ookoro
force-pushed
the
slackNotificationAfter30min
branch
from
4297208 to
0187d15
Compare
andela-ookoro
force-pushed
the
slackNotificationAfter30min
branch
from
0187d15 to
d19805a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request adds a feature which sends a slack notification after a scraping session is running for more than 30 minutes.
You need to export the 'MORPH_WEBHOOK_URL' as it is the identifier to the slack app.