Skip to content

Total time slack notification after timeout of 30 minutes#52

Closed
andela-ookoro wants to merge 4 commits into
CodeForAfrica-SCRAPERS:developfrom
andela-ookoro:totalTimeslackNotificationAfterTimeout
Closed

Total time slack notification after timeout of 30 minutes#52
andela-ookoro wants to merge 4 commits into
CodeForAfrica-SCRAPERS:developfrom
andela-ookoro:totalTimeslackNotificationAfterTimeout

Conversation

@andela-ookoro

Copy link
Copy Markdown
Contributor

This Pull Request adds a feature which sends a slack notification of the total time spent when a scraping session runs for more than 30 minutes.
You need to export the 'MORPH_WEBHOOK_URL' as it is the identifier to the slack app.

@DavidLemayian

Copy link
Copy Markdown
Contributor

Huh? This looks like #51. Is the difference Clinical officers scraping? We should create a separate PR for that.

@andela-ookoro

andela-ookoro commented Oct 28, 2017

Copy link
Copy Markdown
Contributor Author

Nice, I have created a PR for the update on the clinical officer date format.
Previously, this PR sends a notification after a long scraping session (more than 30 minutes, while other PR sends a notification when a scraping session crosses the 30 minutes check mark).
I have added this feature to this PR, as they both send notification when the scraper runs for than 30 minute
Can I delete this PR?

@DavidLemayian

Copy link
Copy Markdown
Contributor

@andel-ookoro Sounds good. I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants