Skip to content

feat(header): add "Go to header" skip link #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cedric07 wants to merge 3 commits into
base: master
Choose a base branch
from
+30 −19
Open

feat(header): add "Go to header" skip link #497

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91500e4
feat(header): add "Go to header" skip link for improved navigation ac…
cedric07 May 7, 2026
32888f7
fix(header): add tabindex to header for improved keyboard navigation
cedric07 May 7, 2026
238c3f8
fix(translations): update French translation for "Go to header" and c…
cedric07 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
<?php wp_body_open(); ?>
<nav class="skip-links skip-links--hidden" aria-label="<?php esc_attr_e( 'Fast access links', 'beapi-frontend-framework' ); ?>">
<ul>
<li>
<a href="#header"><?php esc_html_e( 'Go to header', 'beapi-frontend-framework' ); ?></a>
</li>
Comment thread
cursor[bot] marked this conversation as resolved.
<li class="is-desktop-only">
<a href="#menu"><?php esc_html_e( 'Go to main navigation menu', 'beapi-frontend-framework' ); ?></a>
</li>
Expand All @@ -41,7 +44,7 @@
</li>
</ul>
</nav>
<header role="banner" id="header" class="header" aria-label="<?php esc_attr_e( 'Header', 'beapi-frontend-framework' ); ?>">
<header role="banner" id="header" tabindex="-1" class="header" aria-label="<?php esc_attr_e( 'Header', 'beapi-frontend-framework' ); ?>">
<div class="header__inner">
<div class="container">
<a class="header__logo-link" href="<?php echo esc_url( home_url( '/' ) ); ?>">
Expand Down
20 changes: 12 additions & 8 deletions languages/beapi-frontend-framework.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ msgstr ""
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"POT-Creation-Date: 2026-04-20T12:32:17+00:00\n"
"POT-Creation-Date: 2026-05-07T14:30:39+00:00\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"X-Generator: WP-CLI 2.12.0\n"
"X-Domain: beapi-frontend-framework\n"
Expand Down Expand Up @@ -48,35 +48,39 @@ msgid "Fast access links"
msgstr ""

#: header.php:31
msgid "Go to header"
msgstr ""

#: header.php:34
#: header.php:37
msgid "Go to main navigation menu"
msgstr ""

#: header.php:37
#: header.php:40
msgid "Go to main content"
msgstr ""

#: header.php:40
#: header.php:43
msgid "Go to footer"
msgstr ""

#: header.php:44
#: header.php:47
msgid "Header"
msgstr ""

#: header.php:54
#: header.php:57
msgid "Open the menu"
msgstr ""

#: header.php:55
#: header.php:58
msgid "Close the menu"
msgstr ""

#: header.php:58
#: header.php:61
msgid "Main navigation"
msgstr ""

#: header.php:77
#: header.php:80
msgid "Main content"
msgstr ""

Expand Down
Binary file modified languages/fr_FR.mo
View file
Open in desktop
Binary file not shown.
24 changes: 14 additions & 10 deletions languages/fr_FR.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ msgstr ""
"Project-Id-Version: Be API Frontend Framework 1.0.0\n"
"Report-Msgid-Bugs-To: https://wordpress.org/support/theme/beapi-frontend-"
"framework\n"
"POT-Creation-Date: 2026-04-20T12:32:17+00:00\n"
"PO-Revision-Date: 2026-04-20 14:33+0200\n"
"POT-Creation-Date: 2026-05-07T14:30:39+00:00\n"
"PO-Revision-Date: 2026-05-07 16:32+0200\n"
"Last-Translator: \n"
"Language-Team: \n"
"Language: fr\n"
Expand Down Expand Up @@ -50,35 +50,39 @@ msgstr "Pied de Page"
msgid "Fast access links"
msgstr "Liens d’accès rapide"

#: header.php:31 header.php:34
#: header.php:31
msgid "Go to header"
msgstr "Aller au à l’entête de page"
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated

#: header.php:34 header.php:37
msgid "Go to main navigation menu"
msgstr "Aller au menu de navigation principal"

#: header.php:37
#: header.php:40
msgid "Go to main content"
msgstr "Aller au contenu principal"

#: header.php:40
#: header.php:43
msgid "Go to footer"
msgstr "Aller au pied de page"

#: header.php:44
#: header.php:47
msgid "Header"
msgstr "Entête"

#: header.php:54
#: header.php:57
msgid "Open the menu"
msgstr "Ouvrir le menu"

#: header.php:55
#: header.php:58
msgid "Close the menu"
msgstr "Fermer le menu"

#: header.php:58
#: header.php:61
msgid "Main navigation"
msgstr "Navigation principale"

#: header.php:77
#: header.php:80
msgid "Main content"
msgstr "Contenu principal"

Expand Down
Loading