Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the directory copying functionality by removing the external copy-dir dependency and replacing it with Node.js's built-in fs.cpSync() method. This simplifies the dependency tree and leverages native filesystem capabilities.
Key changes:
- Removed
copy-dirpackage from dependencies - Updated
moveConfigfunction to usefs.cpSync()with an adapted filter function - Modified filter function signature to match
fs.cpSync()API expectations
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Removed copy-dir dependency from the dependencies list |
| yarn.lock | Removed lockfile entry for copy-dir package |
| lib/utils.js | Removed copydir import and replaced two instances of copydir.sync() calls with fs.cpSync(), updating the filter function accordingly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4860bde to
13f8982
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
13f8982 to
880a3f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way directories are copied in the
lib/utils.jsmodule by replacing the use of the externalcopy-dirpackage with Node.js's built-infs.cpSyncmethod. This change simplifies dependencies and streamlines the codebase.Dependency removal and code refactoring:
copy-dirdependency frompackage.jsonand all relatedrequirestatements inlib/utils.js. [1] [2]copydir.syncwith the built-infs.cpSyncmethod, updating the filter function accordingly in themoveConfigfunction inlib/utils.js. [1] [2]See also: Automattic/vip-cli#2295