Feature/multi qr code reader#376
Conversation
odahcam
commented
Dec 4, 2020
- Added support for multiple QR code scanning from the same image.
- Added tests for the feature.
- Updated some classes this feature depends on.
- Updated Sharp.
…ng-js/library into feature/multi-qr-code-reader
|
Based on comments in the UPCEAN Pull-Request discussion this is where we land I think constructor(arg1: any);
constructor(arg1: any, arg2: any);
constructor(arg1: any, arg2: any, arg3: any);
constructor(arg1: any, arg2?: any, arg3?: any) {
if (arg2 == null) arg2 = {};
if (arg3 == null) arg3 = {};
return constructorImpl(arg1, arg2, arg3)
}
constructorImpl(arg1: any, arg2: any, arg3: any) {
/* Implementation code */
}and less preferred if more advanced logic needed constructor(arg1: any);
constructor(arg1: any, arg2: any);
constructor(arg1: any, arg2: any, arg3: any);
constructor(arg1: any, arg2?: any, arg3?: any) {
if (arg3 != null) return constructorImpl(arg1, arg2, arg3);
if (arg2 != null) return constructorOverload2(arg1, arg2);
return constructorOverload1(arg1)
}
private constructorOverload1(
arg1: any,
) {
return this.constructorOverload2(arg1, {});
}
private constructorOverload2(
arg1: any,
arg2: any,
) {
return this.constructorImpl(arg1, arg2, {});
}
private constructorImpl(
arg1: any,
arg2: any,
arg3: any,
) {
/* Implementation code */
} |
|
What massive error I did merging master onto this branch. |
|
Any updates in this PR? I'm trying to use this branch in my project and hope this branch will be merged into master. |
|
|
||
| static processStructuredAppend( results: List<Result>): List<Result> { | ||
| const newResults: List<Result> = []; | ||
| const saResults: List<Result> = []; |
There was a problem hiding this comment.
We need to create multiple saResults: List<Result> that grouped by ResultMetadataType.STRUCTURED_APPEND_PARITY to handle multi parity structured append qr codes in one document.
There was a problem hiding this comment.
Thanks for the tip!! Can you help me with some examples or a PR?
|
i love this PR. |
|
Also bumping this PR. Let me know how I can help. |
|
I made some minor fixes and created PR #464 to merge into |
Fix for feature/multi qr code reader
Resolve conflicts to make multi-QR-code feature compatible with current master (TS6, Jest 30, ESLint 10, Node 24, MicroQR, MaxiCode). Conflict resolutions: - package.json: use master's modern devDependencies - FinderPatternFinder.ts: keep feature branch version (required by MultiFinderPatternFinder) - src/index.ts: merge both export sets (master's CodaBar/FinderPattern + feature's multi-QR) - createDecoder.ts: removed (consolidated into AbstractExpandedDecoderComplement on master) - AssertUtils.ts: use master's typed assertEquals - MultiFormatUPCEANReader.ts: keep feature branch Result constructor call (uses overloads) - .vscode/launch.json: use master's version - yarn.lock: use master's version Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
am I brave enough to merge that? |