Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
strategy:
fail-fast: false
matrix:
phoenix-major: [13, 14]
phoenix-major: [13, 14, 15]

steps:
- uses: actions/checkout@v6
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ classifiers = [
"Typing :: Typed",
]
dependencies = [
"arize-phoenix>=13.0,<15",
"arize-phoenix>=13.0,<16",
"pandas>=2.0",
"click>=8.0",
"jsonschema>=4.0",
Expand Down Expand Up @@ -94,7 +94,7 @@ dev = [
]
demo = [
"evalwire[langgraph,openai]",
"arize-phoenix>=13.0,<15",
"arize-phoenix>=13.0,<16",
"langchain>=1.0,<2",
"langchain-core>=1.0,<2",
"langchain-openai>=1.0,<2",
Expand Down
31 changes: 19 additions & 12 deletions tests/integration/test_uploader_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,21 +66,28 @@ def test_skip_does_not_duplicate(
search_ds = phoenix_client.datasets.get_dataset(dataset=search_tag)
assert len(search_ds) == 2

def test_append_adds_examples(
self, phoenix_client, integration_csv: tuple[Path, str, str]
):
csv_path, search_tag, _router_tag = integration_csv
uploader = DatasetUploader(
csv_path=csv_path,
phoenix_client=phoenix_client,
def test_append_adds_examples(self, phoenix_client, tmp_path: Path):
import uuid

tag = f"append_{uuid.uuid4().hex[:8]}"
csv_2 = tmp_path / "initial.csv"
csv_2.write_text(f"user_query,expected_output,tags\nq1,a1,{tag}\nq2,a2,{tag}\n")
csv_3 = tmp_path / "append.csv"
csv_3.write_text(
f"user_query,expected_output,tags\nq3,a3,{tag}\nq4,a4,{tag}\nq5,a5,{tag}\n"
)
uploader.upload(on_exist="skip")
count_before = len(phoenix_client.datasets.get_dataset(dataset=search_tag))

uploader.upload(on_exist="append")
count_after = len(phoenix_client.datasets.get_dataset(dataset=search_tag))
DatasetUploader(csv_path=csv_2, phoenix_client=phoenix_client).upload(
on_exist="skip"
)
count_before = len(phoenix_client.datasets.get_dataset(dataset=tag))

DatasetUploader(csv_path=csv_3, phoenix_client=phoenix_client).upload(
on_exist="append"
)
count_after = len(phoenix_client.datasets.get_dataset(dataset=tag))

assert count_after == count_before + 2 # 2 more "search" rows
assert count_after == count_before + 3

def test_custom_keys(self, phoenix_client, tmp_path: Path):
import uuid
Expand Down
Loading