fix: overwrite mode now deletes existing dataset before re-creating - #39
Merged
Conversation
Previously, on_exist="overwrite" called create_dataset directly, which
returned a 409 Conflict (DatasetUploadError) when the dataset already
existed. The code incorrectly assumed Phoenix would create a new version.
The fix looks up the existing dataset, deletes it via the REST API
(DELETE /v1/datasets/{id}), then creates a fresh dataset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_exist="overwrite"inDatasetUploaderwhich previously caused a 409 Conflict (DatasetUploadError) when the dataset already existedcreate_datasetwould create a new version for an existing name; it actually rejects duplicatesget_dataset, deletes it via the Phoenix REST API (DELETE /v1/datasets/{id}), then creates a fresh dataset