This repository was archived by the owner on Sep 10, 2019. It is now read-only.
Allow modals to receive a controller, resolvers and a few other options.#689
Open
lunks wants to merge 2 commits into
Open
Allow modals to receive a controller, resolvers and a few other options.#689lunks wants to merge 2 commits into
lunks wants to merge 2 commits into
Conversation
I'm also using `$templateRequest` to fetch the template instead of `$http`. This follows pretty much what angular-ui-bootstrap does for attaching controllers and resolve things around.
Contributor
|
Can you clean this up and only submit changes to relevant individual files? We'll handle creating the /dist files. |
|
What's the status on this? |
Author
|
I left the previous company I was using foundation-apps and forgot about this. I'll do what @zurbchris asked so we can move forward. |
Contributor
|
Feel free to submit this PR against the new fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows pretty much what angular-ui-bootstrap does for attaching controllers and resolve things around.
I've changed the way we fetch templates to use
$templateRequestand I'm exposingmodalInstanceto the controller so we can close it from there if we want to.