Make OPENAI_API_KEY not necessary for Azure OpenAI#137
Open
SjoerdGn wants to merge 2 commits intozou-group:mainfrom
Open
Make OPENAI_API_KEY not necessary for Azure OpenAI#137SjoerdGn wants to merge 2 commits intozou-group:mainfrom
SjoerdGn wants to merge 2 commits intozou-group:mainfrom
Conversation
amadeogranillo
approved these changes
Mar 3, 2025
vinid
reviewed
Mar 3, 2025
| ) | ||
| else: | ||
| raise ValueError("Invalid base URL provided. Please use the default OLLAMA base URL or None.") | ||
| if not azure_openai: |
Collaborator
There was a problem hiding this comment.
This is now getting a bit messy, a possible way of cleaning this up is making a create_client factory that depends on a type in the input client (which defaults to openai).
So something like
__init__(..., client_type: str ...):
self.client = _factory_client_openai(client_type)
and have the checks in the factored classes
any thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current setup still requires you to set any OPENAI_API_KEY in the environment variables when using Azure OpenAI, although it is not used. This code removes this requirement.