Skip to content

feat: add ZipFileData to public API #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kinrany wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

feat: add ZipFileData to public API #860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pub use crate::compression::{CompressionMethod, SUPPORTED_COMPRESSION_METHODS};
pub use crate::datetime::DateTime;
pub use crate::format::aes::AesMode;
pub use crate::format::flags::System;
pub use crate::read::HasZipMetadata;
pub use crate::read::{HasZipMetadata, ZipFileData};

@gemini-code-assist gemini-code-assist Bot Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change will cause a compilation error because ZipFileData is not publicly exported from the read module (crate::read). In src/read/mod.rs, ZipFileData is only imported privately via use crate::types::ZipFileData;.

To fix this, you can either:

  1. Re-export ZipFileData directly from crate::types in src/lib.rs (consistent with how DateTime or System are exported).
  2. Or, if you want it to be accessible via zip::read::ZipFileData as well, you must also modify src/read/mod.rs to publicly export it (pub use crate::types::ZipFileData;).
Suggested change
pub use crate::read::{HasZipMetadata, ZipFileData};
pub use crate::read::HasZipMetadata;
pub use crate::types::ZipFileData;

pub use crate::read::{ZipArchive, ZipReadOptions};
pub use crate::spec::{ZIP64_BYTES_THR, ZIP64_ENTRY_THR};
pub use crate::write::ZipWriter;
Expand Down