Open
Conversation
ikskuh
requested changes
Apr 18, 2026
Member
ikskuh
left a comment
ikskuh
left a comment
There was a problem hiding this comment.
I have one nitpick. Just give me a heads up if you've changed it or if there's no way to change it.
| while (true) { | ||
| _ = try self.reader.streamDelimiterLimit(writer, '\n', .limited(4096)); | ||
| try writer.flush(); | ||
| { |
Member
There was a problem hiding this comment.
I think the Io.Writer.Allocating can be reused here as well, we don't have to use the ArrayList roundtrip here
Author
There was a problem hiding this comment.
Changed in 68228a2
This avoids the ArrayList roundtrip in the parser loop.
Member
There was a problem hiding this comment.
Please drop the ArrayList completely. We don't need it when we can use the Writer.Allocating in the first place.
It's just a deprecated pattern now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the project to Zig 0.16.0.
@cImportwith a translate-c step inbuild.zig.std.IoAPIs.