upgrade as per zig 0.16.0 io interface#27
Open
anshalshukla wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the minimum Zig version to 0.16.0 and migrates the codebase to use the new std.Io interfaces across CID, multihash, and multibase implementations. The changes replace legacy std.io components with std.Io.Reader, std.Io.Writer, and updated file/clock APIs. A technical issue was noted in the benchmarking code where flush() is incorrectly called on the writer's interface rather than the writer object itself.
| var stdout_buf: [4096]u8 = undefined; | ||
| var stdout_writer = std.Io.File.stdout().writer(io, &stdout_buf); | ||
| try bench_res.format(&stdout_writer.interface); | ||
| try stdout_writer.interface.flush(); |
There was a problem hiding this comment.
The std.Io.Writer interface does not contain a flush method. Since stdout_writer is a bound buffered writer, you should call flush() directly on the writer object itself, rather than through its interface field.
try stdout_writer.flush();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.