Skip to content

fix(deploy): reuse existing service by name to prevent duplicates #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stantheman0128 wants to merge 1 commit into from
Closed

fix(deploy): reuse existing service by name to prevent duplicates #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion internal/cmd/deploy/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,26 @@ func runDeploy(f *cmdutil.Factory, opts *Options) error {
if err != nil {
return err
}
} else if !opts.create {
// Look up existing service by name to avoid creating duplicates
existingServices, err := f.ApiClient.ListAllServices(context.Background(), projectID)
if err != nil {
return fmt.Errorf("listing existing services: %w", err)
}
for _, s := range existingServices {
if s.Name == opts.name {
service = s
break
}
}
if service == nil {
service, err = f.ApiClient.CreateEmptyService(context.Background(), projectID, opts.name)
if err != nil {
return err
}
}
} else {
// create a new service
// --create flag: always create a new service
service, err = f.ApiClient.CreateEmptyService(context.Background(), projectID, opts.name)
if err != nil {
return err
Expand Down