Skip to content

ci(common): update protoc setup#602

Merged
eudelins-zama merged 16 commits into
mainfrom
fred/ci/fix-protoc-setup
May 19, 2026
Merged

ci(common): update protoc setup#602
eudelins-zama merged 16 commits into
mainfrom
fred/ci/fix-protoc-setup

Conversation

@fegmorte
Copy link
Copy Markdown
Contributor

Description of changes

Update the protoc setup to get rid off action arduino/setup-protoc that is not well maintained.

Issue ticket number and link

PR Checklist

I attest that all checked items are satisfied. Any deviation is clearly justified above.

  • Title follows conventional commits (e.g. chore: ...).
  • Tests added for every new pub item and test coverage has not decreased.
  • Public APIs and non-obvious logic documented; unfinished work marked as TODO(#issue).
  • unwrap/expect/panic only in tests or for invariant bugs (documented if present).
  • No dependency version changes OR (if changed) only minimal required fixes.
  • No architectural protocol changes OR linked spec PR/issue provided.
  • No breaking deployment config changes OR devops label + infra notified + infra-team reviewer assigned.
  • No breaking gRPC / serialized data changes OR commit marked with ! and affected teams notified.
  • No modifications to existing versionized structs OR backward compatibility tests updated.
  • No critical business logic / crypto changes OR ≥2 reviewers assigned.
  • No new sensitive data fields added OR Zeroize + ZeroizeOnDrop implemented.
  • No new public storage data OR data is verifiable (signature / digest).
  • No unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.
  • Strongly typed boundaries: typed inputs validated at the edge; no untyped values or errors cross modules.
  • Self-review completed.

Dependency Update Questionnaire (only if deps changed or added)

Answer in the Cargo.toml next to the dependency (or here if updating):

  1. Ownership changes or suspicious concentration?
  2. Low popularity?
  3. Unusual version jump?
  4. Lacking documentation?
  5. Missing CI?
  6. No security / disclosure policy?
  7. Significant size increase?

More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md

@cla-bot cla-bot Bot added the cla-signed The CLA has been signed. label May 19, 2026
Comment thread .github/actions/setup-rust-and-protoc/action.yml Fixed
Comment thread .github/actions/setup-rust-and-protoc/action.yml Fixed
Comment thread .github/actions/setup-rust-and-protoc/action.yml Fixed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

Consolidated Tests Results 2026-05-19 - 17:32:03

Test Results

passed 7 passed

Details

tests 7 tests
clock not captured
tool junit-to-ctrf
build build-and-test arrow-right test-reporter link #2246
pull-request ci(common): update protoc setup link #602

test-reporter: Run #2246

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
7 7 0 0 0 0 0 not captured

🎉 All tests passed!

Tests

View All Tests
Test Name Status Flaky Duration
k8s_test_crs_uniqueness 41.4s
k8s_test_insecure_keygen_encrypt_and_public_decrypt 1m 54s
k8s_test_insecure_keygen_encrypt_multiple_types 2m 6s
k8s_test_keygen_and_crs 1m 55s
k8s_test_keygen_uniqueness 4m 50s
k8s_test_centralized_insecure 52.9s
nightly_full_gen_tests_default_k8s_centralized_sequential_crs 1.6s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Replaces the third-party arduino/setup-protoc action with an inline curl + sha256sum + unzip install in the shared setup-rust-and-protoc composite action, and removes the now-obsolete protoc-version / protoc-repo-token inputs from every workflow that invoked it. The default protoc version is also bumped from 26.1 to 34.1.

Changes:

  • Inline manual download of protoc (Linux x86_64) with a pinned SHA-256, removing the dependency on arduino/setup-protoc and the GitHub-token rate-limit workaround.
  • Drop the protoc-repo-token input and stop passing protoc-version / protoc-repo-token from all callers, relying on the action default.
  • Bump the default protoc version from 26.1 to 34.1.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/actions/setup-rust-and-protoc/action.yml Replace arduino/setup-protoc with a manual curl/sha256sum/unzip install; remove protoc-repo-token input; bump default version to 34.1.
.github/workflows/common-testing.yml Drop now-removed protoc-version / protoc-repo-token inputs.
.github/workflows/kind-testing.yml Same input cleanup.
.github/workflows/main.yml Same input cleanup.
.github/workflows/npm-release.yml Same input cleanup.
.github/workflows/pr-preview-deploy.yml Same input cleanup.
.github/workflows/rust-lint.yml Same input cleanup.
.github/workflows/wasm-testing.yml Same input cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/actions/setup-rust-and-protoc/action.yml Outdated
Comment thread .github/actions/setup-rust-and-protoc/action.yml Outdated
Comment thread .github/actions/setup-rust-and-protoc/action.yml Outdated
@fegmorte fegmorte marked this pull request as ready for review May 19, 2026 12:40
@fegmorte fegmorte requested review from a team as code owners May 19, 2026 12:40
Comment thread .github/zizmor.yml Outdated
@fegmorte fegmorte requested review from dd23 and eudelins-zama May 19, 2026 16:38
Copy link
Copy Markdown
Member

@dd23 dd23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@eudelins-zama eudelins-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@eudelins-zama eudelins-zama merged commit 9e9b149 into main May 19, 2026
60 checks passed
@eudelins-zama eudelins-zama deleted the fred/ci/fix-protoc-setup branch May 19, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants