ci(common): update protoc setup#602
Conversation
Consolidated Tests Results 2026-05-19 - 17:32:03Test ResultsDetails
test-reporter: Run #2246
🎉 All tests passed!TestsView All Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
There was a problem hiding this comment.
Pull request overview
Replaces the third-party arduino/setup-protoc action with an inline curl + sha256sum + unzip install in the shared setup-rust-and-protoc composite action, and removes the now-obsolete protoc-version / protoc-repo-token inputs from every workflow that invoked it. The default protoc version is also bumped from 26.1 to 34.1.
Changes:
- Inline manual download of protoc (Linux x86_64) with a pinned SHA-256, removing the dependency on
arduino/setup-protocand the GitHub-token rate-limit workaround. - Drop the
protoc-repo-tokeninput and stop passingprotoc-version/protoc-repo-tokenfrom all callers, relying on the action default. - Bump the default protoc version from 26.1 to 34.1.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/actions/setup-rust-and-protoc/action.yml | Replace arduino/setup-protoc with a manual curl/sha256sum/unzip install; remove protoc-repo-token input; bump default version to 34.1. |
| .github/workflows/common-testing.yml | Drop now-removed protoc-version / protoc-repo-token inputs. |
| .github/workflows/kind-testing.yml | Same input cleanup. |
| .github/workflows/main.yml | Same input cleanup. |
| .github/workflows/npm-release.yml | Same input cleanup. |
| .github/workflows/pr-preview-deploy.yml | Same input cleanup. |
| .github/workflows/rust-lint.yml | Same input cleanup. |
| .github/workflows/wasm-testing.yml | Same input cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description of changes
Update the protoc setup to get rid off action
arduino/setup-protocthat is not well maintained.Issue ticket number and link
PR Checklist
I attest that all checked items are satisfied. Any deviation is clearly justified above.
chore: ...).TODO(#issue).unwrap/expect/paniconly in tests or for invariant bugs (documented if present).devopslabel + infra notified + infra-team reviewer assigned.!and affected teams notified.Zeroize+ZeroizeOnDropimplemented.unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.Dependency Update Questionnaire (only if deps changed or added)
Answer in the
Cargo.tomlnext to the dependency (or here if updating):More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md