Skip to content

Kc1212/chore/3028/autodetect serializable types#597

Draft
kc1212 wants to merge 9 commits into
mainfrom
kc1212/chore/3028/autodetect-serializable-types
Draft

Kc1212/chore/3028/autodetect serializable types#597
kc1212 wants to merge 9 commits into
mainfrom
kc1212/chore/3028/autodetect-serializable-types

Conversation

@kc1212
Copy link
Copy Markdown
Contributor

@kc1212 kc1212 commented May 18, 2026

Description of changes

Issue ticket number and link

PR Checklist

I attest that all checked items are satisfied. Any deviation is clearly justified above.

  • Title follows conventional commits (e.g. chore: ...).
  • Tests added for every new pub item and test coverage has not decreased.
  • Public APIs and non-obvious logic documented; unfinished work marked as TODO(#issue).
  • unwrap/expect/panic only in tests or for invariant bugs (documented if present).
  • No dependency version changes OR (if changed) only minimal required fixes.
  • No architectural protocol changes OR linked spec PR/issue provided.
  • No breaking deployment config changes OR devops label + infra notified + infra-team reviewer assigned.
  • No breaking gRPC / serialized data changes OR commit marked with ! and affected teams notified.
  • No modifications to existing versionized structs OR backward compatibility tests updated.
  • No critical business logic / crypto changes OR ≥2 reviewers assigned.
  • No new sensitive data fields added OR Zeroize + ZeroizeOnDrop implemented.
  • No new public storage data OR data is verifiable (signature / digest).
  • No unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.
  • Strongly typed boundaries: typed inputs validated at the edge; no untyped values or errors cross modules.
  • Self-review completed.

Dependency Update Questionnaire (only if deps changed or added)

Answer in the Cargo.toml next to the dependency (or here if updating):

  1. Ownership changes or suspicious concentration?
  2. Low popularity?
  3. Unusual version jump?
  4. Lacking documentation?
  5. Missing CI?
  6. No security / disclosure policy?
  7. Significant size increase?

More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md

kc1212 added 7 commits May 11, 2026 17:58
This is a simple check to ensure that all the versioned types that are present
in the source file also exist in one of the .ron files. It does not check that
all versions for all types are tested because the version number is not stored
in the .ron files.

Closes zama-ai/kms-internal#3026
@kc1212 kc1212 self-assigned this May 18, 2026
@kc1212 kc1212 requested a review from a team as a code owner May 18, 2026 07:48
@cla-bot cla-bot Bot added the cla-signed The CLA has been signed. label May 18, 2026
@kc1212 kc1212 marked this pull request as draft May 18, 2026 07:48
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Consolidated Tests Results 2026-05-19 - 09:15:38

Test Results

passed 7 passed

Details

tests 7 tests
clock not captured
tool junit-to-ctrf
build build-and-test arrow-right test-reporter link #2202
pull-request Kc1212/chore/3028/autodetect serializable types link #597

test-reporter: Run #2202

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
7 7 0 0 0 0 0 not captured

🎉 All tests passed!

Tests

View All Tests
Test Name Status Flaky Duration
k8s_test_crs_uniqueness 42.7s
k8s_test_insecure_keygen_encrypt_and_public_decrypt 2m 6s
k8s_test_insecure_keygen_encrypt_multiple_types 2m 17s
k8s_test_keygen_and_crs 2m 7s
k8s_test_keygen_uniqueness 5m 6s
k8s_test_centralized_insecure 1m 1s
nightly_full_gen_tests_default_k8s_centralized_sequential_crs 1.8s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant