Skip to content

chore: setup new backwards compatibility tests#594

Merged
jot2re merged 6 commits into
mainfrom
tore/chore/new-backwards-tests
May 20, 2026
Merged

chore: setup new backwards compatibility tests#594
jot2re merged 6 commits into
mainfrom
tore/chore/new-backwards-tests

Conversation

@jot2re
Copy link
Copy Markdown
Collaborator

@jot2re jot2re commented May 15, 2026 •
edited
Loading

Description of changes

Adds new backwards compatibility tests for the next release.
Also removes custodian based tests. The reason being they are not deployed yet, and will be changed in this PR, thus they would need to be removed regardless

Issue ticket number and link

PR Checklist

I attest that all checked items are satisfied. Any deviation is clearly justified above.

  • Title follows conventional commits (e.g. chore: ...).
  • Tests added for every new pub item and test coverage has not decreased.
  • Public APIs and non-obvious logic documented; unfinished work marked as TODO(#issue).
  • unwrap/expect/panic only in tests or for invariant bugs (documented if present).
  • No dependency version changes OR (if changed) only minimal required fixes.
  • No architectural protocol changes OR linked spec PR/issue provided.
  • No breaking deployment config changes OR devops label + infra notified + infra-team reviewer assigned.
  • No breaking gRPC / serialized data changes OR commit marked with ! and affected teams notified.
  • No modifications to existing versionized structs OR backward compatibility tests updated.
  • No critical business logic / crypto changes OR ≥2 reviewers assigned.
  • No new sensitive data fields added OR Zeroize + ZeroizeOnDrop implemented.
  • No new public storage data OR data is verifiable (signature / digest).
  • No unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.
  • Strongly typed boundaries: typed inputs validated at the edge; no untyped values or errors cross modules.
  • Self-review completed.

Dependency Update Questionnaire (only if deps changed or added)

Answer in the Cargo.toml next to the dependency (or here if updating):

  1. Ownership changes or suspicious concentration?
  2. Low popularity?
  3. Unusual version jump?
  4. Lacking documentation?
  5. Missing CI?
  6. No security / disclosure policy?
  7. Significant size increase?

More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md

@jot2re jot2re requested a review from a team as a code owner May 15, 2026 10:21
@cla-bot cla-bot Bot added the cla-signed The CLA has been signed. label May 15, 2026
@jot2re jot2re requested a review from dd23 May 15, 2026 10:21
jot2re
jot2re commented May 15, 2026
View reviewed changes
Comment thread backward-compatibility/generate-v0.14.0/src/data_0_14.rs
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026 •
edited
Loading

Consolidated Tests Results 2026-05-19 - 16:20:43

Test Results

passed 7 passed

Details

tests 7 tests
clock not captured
tool junit-to-ctrf
build build-and-test arrow-right test-reporter link #2234
pull-request chore: setup new backwards compatibility tests link #594

test-reporter: Run #2234

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
7 7 0 0 0 0 0 not captured

🎉 All tests passed!

Tests

View All Tests
Test Name Status Flaky Duration
k8s_test_crs_uniqueness ✅ 43.2s
k8s_test_insecure_keygen_encrypt_and_public_decrypt ✅ 2m 4s
k8s_test_insecure_keygen_encrypt_multiple_types ✅ 2m 18s
k8s_test_keygen_and_crs ✅ 2m 5s
k8s_test_keygen_uniqueness ✅ 5m 9s
k8s_test_centralized_insecure ✅ 56.1s
nightly_full_gen_tests_default_k8s_centralized_sequential_crs ✅ 1.8s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

kc1212
kc1212 previously approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kc1212 kc1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the removal, everything else LGTM

Comment thread backward-compatibility/generate-v0.13.20/src/data_0_13.rs
dvdplm
dvdplm previously approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a blind approval here, given LFS and whatnot.

One question I have is if the Cargo.lock for generate-v0.14.0 deletion was intentional. The other versions seem to have kept their lock files.

@dd23 dd23 requested a review from Copilot May 19, 2026 12:03
Copilot AI reviewed May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the backward-compatibility testing infrastructure to cover the upcoming 0.14.0 release by adding a new data generator crate and committing the newly generated artifacts, while also removing custodian-backup-related test generation from the 0.13.20 generator.

Changes:

  • Added generate-v0.14.0 generator crate + Makefile/doc wiring and generated 0_14_0 backward-compatibility artifacts.
  • Removed custodian backup test generation from the generate-v0.13.20 generator.
  • Bumped workspace/package versions to 0.14.0-0 and refreshed relevant lockfiles / metadata files.

Reviewed changes

Copilot reviewed 78 out of 88 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
Makefile Adds v0.14.0 BC generation target and includes it in generate-backward-compatibility-all.
docs/developer/backward_compatibility.md Documents the new v0.14.0 generator and command.
Cargo.toml Updates workspace exclusion list and bumps workspace version to 0.14.0-0.
Cargo.lock Updates workspace crate versions to 0.14.0-0.
backward-compatibility/generate-v0.14.0/src/main.rs New v0.14.0 generator entrypoint wiring metadata storage.
backward-compatibility/generate-v0.14.0/src/lib.rs New v0.14.0 generator crate module exports.
backward-compatibility/generate-v0.14.0/src/generate.rs Shared generator utilities for v0.14.0.
backward-compatibility/generate-v0.14.0/src/data_0_14.rs v0.14.0-specific data generation implementation.
backward-compatibility/generate-v0.14.0/Cargo.toml New generator crate manifest pinned to KMS v0.14.0 dependencies.
backward-compatibility/generate-v0.13.20/src/data_0_13.rs Removes custodian backup-related test generation for v0.13.20.
backward-compatibility/generate-v0.13.10/Cargo.lock Updates lockfile to reference backward-compatibility v0.14.0.
backward-compatibility/generate-v0.13.0/Cargo.lock Updates lockfile to reference backward-compatibility v0.14.0.
backward-compatibility/generate-v0.11.1/Cargo.lock Updates lockfile to reference backward-compatibility v0.14.0.
backward-compatibility/generate-v0.11.0/Cargo.lock Updates lockfile to reference backward-compatibility v0.14.0.
backward-compatibility/data/threshold-fhe.ron Appends v0.14.0 threshold-fhe test metadata.
backward-compatibility/data/kms.ron Appends v0.14.0 kms test metadata.
backward-compatibility/data/kms-grpc.ron Appends v0.14.0 kms-grpc test metadata.
backward-compatibility/data/0_14_0/threshold-fhe/share_64.bcode Adds v0.14.0 threshold-fhe serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/threshold-fhe/share_128.bcode Adds v0.14.0 threshold-fhe serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/threshold-fhe/release_pcr_values.bcode Adds v0.14.0 threshold-fhe serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/threshold-fhe/prss_setup_rpoly_64.bcode Adds v0.14.0 threshold-fhe serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/threshold-fhe/prss_setup_rpoly_128.bcode Adds v0.14.0 threshold-fhe serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/threshold-fhe/prss_set_64.bcode Adds v0.14.0 threshold-fhe serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/threshold-fhe/prss_set_128.bcode Adds v0.14.0 threshold-fhe serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/threshold-fhe/prf_key.bcode Adds v0.14.0 threshold-fhe serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/threshold-fhe/auxiliary_prss_set_64/legacy_prss_set_64.bcode Adds v0.14.0 threshold-fhe auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/threshold-fhe/auxiliary_prss_set_128/legacy_prss_set_128.bcode Adds v0.14.0 threshold-fhe auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/unified_signcryption.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/unified_ciphertext.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/typed_plaintext.bincode Adds v0.14.0 kms serialized artifact (inline bincode).
backward-compatibility/data/0_14_0/kms/threshold_fhe_keys.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/software_version.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/signcryption_payload.bincode Adds v0.14.0 kms serialized artifact (inline bincode).
backward-compatibility/data/0_14_0/kms/signcryption_key.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/recovery_material.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/public_sig_key.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/prss_setup_combined.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/private_sig_key.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/operator_backup_output.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/node_info.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/kms_fhe_key_handles.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/key_gen_metadata.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/key_gen_metadata_with_extra_data.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/internal_recovery_request.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/internal_custodian_setup_message.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/internal_custodian_recovery_output.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/internal_cus_context.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/hybrid_kem_ct.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/designcryption_key.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/crs_gen_metadata.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/crs_gen_metadata_with_extra_data.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/context_info.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/backup_ciphertext.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_unified_ciphertext/hybrid_kem_ct_handle.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_threshold_fhe_keys/sns_key.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_threshold_fhe_keys/private_key_set.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_threshold_fhe_keys/integer_server_key.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_threshold_fhe_keys/info.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_threshold_fhe_keys/decompression_key.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_recovery_material/internal_cus_context_handle.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_prss_setup_combined/prss_setup_64.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_prss_setup_combined/prss_setup_128.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_kms_fhe_key_handles/sig_key_handle.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_kms_fhe_key_handles/server_key_handle.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_kms_fhe_key_handles/public_key_handle.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_kms_fhe_key_handles/decompression_key.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_kms_fhe_key_handles/client_key_handle.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_key_gen_metadata/legacy_key_gen_metadata.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_internal_cus_context/unified_enc_key_handle.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_crs_gen_metadata/legacy_crs_gen_metadata.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/auxiliary_backup_ciphertext/unified_ciphertext_handle.bcode Adds v0.14.0 kms auxiliary artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms/app_key_blob.bcode Adds v0.14.0 kms serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms-grpc/signed_pub_data_handle_internal.bcode Adds v0.14.0 kms-grpc serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms-grpc/pub_data_type.bcode Adds v0.14.0 kms-grpc serialized artifact (LFS pointer).
backward-compatibility/data/0_14_0/kms-grpc/priv_data_type.bcode Adds v0.14.0 kms-grpc serialized artifact (LFS pointer).
backward-compatibility/data/0_13_10/kms/kms_fhe_key_handles.bcode Updates existing artifact pointer (regen).
backward-compatibility/data/0_13_10/kms/key_gen_metadata.bcode Updates existing artifact pointer (regen).
backward-compatibility/data/0_13_10/kms/auxiliary_key_gen_metadata/legacy_key_gen_metadata.bcode Updates existing artifact pointer (regen).
backward-compatibility/data/0_13_0/kms/kms_fhe_key_handles.bcode Updates existing artifact pointer (regen).
backward-compatibility/data/0_13_0/kms/auxiliary_key_gen_metadata/legacy_key_gen_metadata.bcode Updates existing artifact pointer (regen).
backward-compatibility/data/0_11_1/kms/kms_fhe_key_handles.bcode Updates existing artifact pointer (regen).
backward-compatibility/data/0_11_0/kms/kms_fhe_key_handles.bcode Updates existing artifact pointer (regen).
backward-compatibility/Cargo.toml Bumps backward-compatibility crate version to 0.14.0.
backward-compatibility/Cargo.lock Removes the backward-compatibility sub-crate lockfile.
backward-compatibility/ADDING_NEW_VERSIONS.md Updates generator/version matrix to include v0.14.0 and clarifies active generators.
ai-docs/COMMANDS.md Documents the new make generate-backward-compatibility-v0.14.0 command.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread backward-compatibility/data/kms.ron
Comment thread backward-compatibility/data/kms-grpc.ron
Comment thread backward-compatibility/data/threshold-fhe.ron
Comment thread backward-compatibility/generate-v0.14.0/Cargo.toml Outdated
Comment thread backward-compatibility/generate-v0.14.0/src/data_0_14.rs
Comment thread backward-compatibility/generate-v0.14.0/src/generate.rs
@jot2re jot2re dismissed stale reviews from dvdplm and kc1212 via c535aa7 May 19, 2026 14:25
@jot2re jot2re requested review from dvdplm and kc1212 May 19, 2026 14:34
@kc1212 kc1212 mentioned this pull request May 19, 2026
Draft
15 tasks
@jot2re jot2re merged commit 668b04d into main May 20, 2026
82 of 84 checks passed
@jot2re jot2re deleted the tore/chore/new-backwards-tests branch May 20, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dd23 dd23 dd23 approved these changes

@kc1212 kc1212 kc1212 approved these changes

@dvdplm dvdplm Awaiting requested review from dvdplm

Assignees

No one assigned

Labels

cla-signed The CLA has been signed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jot2re @dvdplm @dd23 @kc1212