chore: matmul cleanup#585
Open
dvdplm wants to merge 21 commits into
Open
Conversation
sprinkled a few quesitions/notices for reviewers, added some validation where strictly needed, stop returning Result when code is infallible
add: DoublePoly::from_bivariate helper
…efault` derivation
chore: moved compute_powers* to matrix
opt: do "outer Horner" for full_eval opt: see if avoiding indexing is faster (avoids bounds checks)
Consolidated Tests Results 2026-05-11 - 12:59:49Test ResultsDetails
test-reporter: Run #2056
🎉 All tests passed!TestsView All Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the bi-variate poly opt (PR #576), the matmul code left was not doing very much. This PR cleans that up a bit by introducing a
VdmMatrixtype and implement only the math we need:On my machine the new code is ~45% faster for the sizes we use (n=13, t=4):
Also removes the
ndarraycrate from the workspace.