chore: changes moby/stairway#564
Open
titouantanguy wants to merge 61 commits into
Open
Conversation
Consolidated Tests Results 2026-05-19 - 10:20:53Test Results
Details
test-reporter: Run #2209
🎉 All tests passed!TestsView All Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
titouantanguy
force-pushed
the
titouan/chore/minor-nist-bench
branch
from
9469e5d to
6b32d44
Compare
dd23
reviewed
May 12, 2026
dd23
reviewed
May 12, 2026
dd23
reviewed
May 12, 2026
dd23
reviewed
May 12, 2026
dvdplm
previously approved these changes
May 18, 2026
| # - (For tfhe only) a resharing of the key generated during DKG | ||
| # - A bunch of decryptons | ||
| # | ||
| # We note that the key generation and the CRS and resahre (when applicable) are checked against a |
Contributor
There was a problem hiding this comment.
Suggested change
| # We note that the key generation and the CRS and resahre (when applicable) are checked against a | |
| # We note that the key generation and the CRS and reshare (when applicable) are checked against a |
| #[clap(long = "sid")] | ||
| session_id: Option<u128>, | ||
|
|
||
| /// Number of Ciphertexts to decrypt per session (Note the provided ctxt will be copied this many times on the server side) |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Number of Ciphertexts to decrypt per session (Note the provided ctxt will be copied this many times on the server side) | |
| /// Number of ciphertexts to decrypt per session (Note the provided ctxt will be copied this many times on the server side) |
|
|
||
| /// Optional argument to set the master seed used by the parties. | ||
| /// Parties will then add their party index to the seed. | ||
| /// Sampled at random if nothing is given |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Sampled at random if nothing is given | |
| /// Sampled at random if not provided. |
Comment on lines
+355
to
+356
| let ctxt_serialized = std::fs::read(params.input_file)?; | ||
| let ctxt: LevelEllCiphertext = bc2wrap::deserialize_unsafe(&ctxt_serialized)?; |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Probably not super high priority to enhance this (even more so since once this PR gets in, I'll copy the code to the NIST repo and hopefully never touch it again)
| } | ||
|
|
||
| // NOTE: Integrated here means we are doing both the preprocessing and online phase | ||
| // in the same call. This denotes a bit with how DKG or DDec is done, but makes it easier |
Contributor
There was a problem hiding this comment.
"denotes"? Do you mean something like "This is a bit like how DKG or DDec do it…"?
Contributor
Author
There was a problem hiding this comment.
meant to write differs, my bad
Comment on lines
+20
to
+26
| The crate at `core/experiments` is **not** a | ||
| production crate: it is the testing/benchmarking harness that wires the | ||
| `threshold-*` crates together, ships the MPC party and choreographer binaries | ||
| used to drive end-to-end runs, and contains the benchmark suite. This page | ||
| describes how to run those benchmarks in a wide range of configurations. | ||
| For the rest of this page, we assume the user is working under the | ||
| `core/experiments` directory. |
Contributor
There was a problem hiding this comment.
The text is great. Seems like the line wrapping might be a bit off on the first line though?
|
|
||
| Between each phase it tears the docker containers down via | ||
| `cleanup_docker`, so each cluster starts from a clean slate. | ||
| - `non-threshold-tfhe-bench.sh` — runs the speed and memory non-threshold |
Contributor
There was a problem hiding this comment.
If we're being pedantic I think that "speed benchmark" is not wholly accurate. Should be "runtime" or "execution time" I think...
Contributor
Author
There was a problem hiding this comment.
Change speed by execution time everywhere in chore: docfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue ticket number and link
PR Checklist
I attest that all checked items are satisfied. Any deviation is clearly justified above.
chore: ...).TODO(#issue).unwrap/expect/paniconly in tests or for invariant bugs (documented if present).devopslabel + infra notified + infra-team reviewer assigned.!and affected teams notified.Zeroize+ZeroizeOnDropimplemented.unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.Dependency Update Questionnaire (only if deps changed or added)
Answer in the
Cargo.tomlnext to the dependency (or here if updating):More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md