Skip to content

TEST: introduce hints for batches reconstruction#559

Closed
titouantanguy wants to merge 1 commit into
mainfrom
titouan/chore/batch-reconstruction-with-hints
Closed

TEST: introduce hints for batches reconstruction#559
titouantanguy wants to merge 1 commit into
mainfrom
titouan/chore/batch-reconstruction-with-hints

Conversation

@titouantanguy
Copy link
Copy Markdown
Contributor

@titouantanguy titouantanguy commented Apr 30, 2026

Description of changes

First try at factoring out all the computation for common information required for reconstructing a batch of shares coming from the same set of parties.

Issue ticket number and link

PR Checklist

I attest that all checked items are satisfied. Any deviation is clearly justified above.

  • Title follows conventional commits (e.g. chore: ...).
  • Tests added for every new pub item and test coverage has not decreased.
  • Public APIs and non-obvious logic documented; unfinished work marked as TODO(#issue).
  • unwrap/expect/panic only in tests or for invariant bugs (documented if present).
  • No dependency version changes OR (if changed) only minimal required fixes.
  • No architectural protocol changes OR linked spec PR/issue provided.
  • No breaking deployment config changes OR devops label + infra notified + infra-team reviewer assigned.
  • No breaking gRPC / serialized data changes OR commit marked with ! and affected teams notified.
  • No modifications to existing versionized structs OR backward compatibility tests updated.
  • No critical business logic / crypto changes OR ≥2 reviewers assigned.
  • No new sensitive data fields added OR Zeroize + ZeroizeOnDrop implemented.
  • No new public storage data OR data is verifiable (signature / digest).
  • No unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.
  • Strongly typed boundaries: typed inputs validated at the edge; no untyped values or errors cross modules.
  • Self-review completed.

Dependency Update Questionnaire (only if deps changed or added)

Answer in the Cargo.toml next to the dependency (or here if updating):

  1. Ownership changes or suspicious concentration?
  2. Low popularity?
  3. Unusual version jump?
  4. Lacking documentation?
  5. Missing CI?
  6. No security / disclosure policy?
  7. Significant size increase?

More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md

@cla-bot cla-bot Bot added the cla-signed The CLA has been signed. label Apr 30, 2026
@titouantanguy titouantanguy force-pushed the titouan/chore/batch-reconstruction-with-hints branch from 7a40852 to f1d2cf1 Compare April 30, 2026 09:38
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

Consolidated Tests Results 2026-04-30 - 10:42:18

Test Results

passed 15 passed

Details

tests 15 tests
clock not captured
tool junit-to-ctrf
build build-and-test arrow-right test-reporter link #1810
pull-request TEST: introduce hints for batches reconstruction link #559

test-reporter: Run #1810

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
15 15 0 0 0 0 0 not captured

🎉 All tests passed!

Tests

View All Tests
Test Name Status Flaky Duration
k8s_test_crs_uniqueness 34.3s
k8s_test_insecure_keygen_encrypt_and_public_decrypt 2m 16s
k8s_test_insecure_keygen_encrypt_multiple_types 2m 32s
k8s_test_keygen_and_crs 2m 13s
k8s_test_keygen_uniqueness 5m 44s
k8s_test_crs_uniqueness 34.1s
k8s_test_insecure_keygen_encrypt_and_public_decrypt 2m 12s
k8s_test_insecure_keygen_encrypt_multiple_types 2m 26s
k8s_test_keygen_and_crs 2m 7s
k8s_test_keygen_uniqueness 5m 31s
k8s_test_crs_uniqueness 34.1s
k8s_test_insecure_keygen_encrypt_and_public_decrypt 2m 12s
k8s_test_insecure_keygen_encrypt_multiple_types 2m 26s
k8s_test_keygen_and_crs 2m 7s
k8s_test_keygen_uniqueness 5m 31s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@titouantanguy
Copy link
Copy Markdown
Contributor Author

Performance test don't indicate any meaningful improvement; but the whole thing was vibecoded and I didn't check in details so maybe worth coming back to the idea at some point.
Closing the PR but leaving the branch for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant