Skip to content

fix race condition in RedisStore ussing redis client watcher #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodrigoirala wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix race condition in RedisStore ussing redis client watcher #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 29 additions & 16 deletions src/RedisStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ class RedisStore extends Store {
this.client = redis.createClient(config);
this.client.on('error', (err) => console.log('Redis Client Error', err));
this.client.connect()


this.txAttempts = config.txAttempts || 1;
}

/**
Expand All @@ -50,22 +49,36 @@ class RedisStore extends Store {
*/
async _hit(key, options, weight) {

let [counter, dateEnd] = await this.client.multi().get(key).ttl(key).exec();

if(counter === null) {
counter = weight;
dateEnd = Date.now() + options.interval;

const seconds = Math.ceil(options.interval / 1000);
await this.client.setEx(key, seconds.toString(), counter.toString());
} else if (dateEnd === -2 || dateEnd === -1) {
counter = counter + weight;
dateEnd = Date.now() + options.interval;
let [counter, dateEnd] = [weight, Date.now() + options.interval];

for (let attempts=0; attempts < this.txAttempts; attempts++ ){
await this.client.watch(key);
try{
counter = await this.client.get(key);
dateEnd = await this.client.ttl(key);
} catch (err) {
console.log(err);
}

const seconds = Math.ceil(options.interval / 1000);
await this.client.setEx(key, seconds.toString(), counter.toString());
} else {
counter = await this.client.incrBy(key, weight);
if(counter === null || dateEnd === -2 || dateEnd === -1) {
if ((dateEnd === -2 || dateEnd === -1)){
counter = counter + weight;
}
try{
await this.client.multi().setEx(key, seconds.toString(), counter.toString()).exec();
break; //ends loop in case of success
} catch (err) {
console.log(err);
}
} else {
try{
counter = await this.client.multi().incrBy(key, weight).exec();
break; //ends loop in case of success
} catch (err) {
console.log(err);
}
}
}

return {
Expand Down