Open
Conversation
Currently reading from a request can hang forever if there is no content available (e.g. GET / HEAD / DELETE / ...). This adds a check if any of the content headers are there to indicate that actually something can be read.
Author
|
Okay that don't work, because it seems some tests write a body without any content headers (what theoretically is allowed for HTTP 1.0 on connection close)... I'll have to think a little bit more about this. |
Owner
|
@laeubi Thanks for your contribution! Unfortunately, we can't merge it without tests. Every feature we add and every bug we fix must be accompanied by at least one new test that confirms that the code was not working before. Without such a test, how can we know that what you commit actually works? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently reading from a request can hang forever if there is no content available (e.g. GET / HEAD / DELETE / ...).
This adds a check if any of the content headers are there to indicate that actually something can be read.
Follow-Up for