update Sanctuary dependencies to latest versions#14
Merged
Conversation
…id Chambers, "We need t._test ([]) rather than t._test because _test now takes an environment as its first argument. We were only partially applying the predicate, which meant we were always getting back a function which was then coerced to true.")
davidchambers
approved these changes
Nov 10, 2019
Contributor
davidchambers
left a comment
davidchambers
left a comment
There was a problem hiding this comment.
These changes look fantastic!
Member
|
Thanks, folks, this is great! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't use hm-def with latest Sanctuary, so I updated all the libs to their latest version, with the help of @davidchambers :
I also had to fix tests, and replaced assertType() by assertTypes():