Skip to content

fix: detect externally installed ACP agents#286

Open
H1d3rOne wants to merge 1 commit into
xintaofei:mainfrom
H1d3rOne:fix/npx-agent-version-detection
Open

fix: detect externally installed ACP agents#286
H1d3rOne wants to merge 1 commit into
xintaofei:mainfrom
H1d3rOne:fix/npx-agent-version-detection

Conversation

@H1d3rOne

Copy link
Copy Markdown

Summary

  • broaden ACP agent detection beyond Codeg-managed install records
  • detect npm/NPX agents from global package metadata, npm prefix shims, and --version output, using unknown when launchable but version is not provable
  • distinguish upstream Claude/Codex CLIs from required ACP adapters in Settings and connect-block messaging
  • allow system binary fallbacks for binary agents, including OpenCode CLI packaged at macOS app-bundle paths
  • align uvx/Hermes readiness with system uvx / system hermes fallbacks so Settings, preflight, and connect gating agree

Verification

  • cargo check
  • cargo clippy --all-targets --features test-utils -- -D warnings
  • cargo test --features test-utils commands::acp::tests::
  • pnpm eslint .
  • pnpm vitest run src/components/settings/acp-agent-settings.test.tsx
  • git diff --check

Expand agent detection beyond Codeg-managed install records: resolve npm shims/package metadata, detect upstream Claude/Codex CLIs separately from ACP adapters, accept system binaries including OpenCode CLI app-bundle paths, and align uvx/Hermes readiness with system CLI fallbacks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant