Skip to content

Add GetPrimaryKeyColumns helper#972

Open
kvch wants to merge 1 commit into
mainfrom
pk-resolution-catalog-helper
Open

Add GetPrimaryKeyColumns helper#972
kvch wants to merge 1 commit into
mainfrom
pk-resolution-catalog-helper

Conversation

@kvch

@kvch kvch commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR adds the new helper GetPrimaryKeyColumns. This will be used in the new position tracking based on PKs.

Related Issue(s)

Type of Change

Please select the relevant option(s):

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test coverage improvement
  • 🔨 Build/CI changes
  • 🧹 Code cleanup

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • All existing tests pass

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Code is well-commented
  • Documentation updated where necessary

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/xataio/pgstream/internal/postgres 31.37% (+1.58%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/xataio/pgstream/internal/postgres/pg_primary_key.go 100.00% (+100.00%) 13 (+13) 13 (+13) 0 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/xataio/pgstream/internal/postgres/pg_primary_key_test.go

@kvch kvch changed the title Add GetPrimaryKeyColumns helper Add GetPrimaryKeyColumns helper Jul 7, 2026
@kvch kvch requested a review from exekias July 7, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Snapshots] PK snapshot: PK-resolution catalog helper

1 participant